Add a GIT_TEST_PROTOCOL_VERSION=X test mode
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | tests: add a special setup where for protocol.versionprotocol.c t/ | +16 | 46 replies | |
| 2/3 | tests: mark tests broken under GIT_TEST_PROTOCOL_VERSION=1t/ t/ t/ +2 more | +5 | 0 replies | |
| 3/3 | tests: mark tests broken under GIT_TEST_PROTOCOL_VERSION=2t/ t/ t/ +7 more | +22 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Add a GIT_TEST_PROTOCOL_VERSION=X test mode
Quoted 8 lines · Jeff King
Quoted 6 lines · Ævar Arnfjörð Bjarmason
Quoted 5 lines
I don't know if there's a good solution. I tried running the whole test suite with v2 as the default. It does find this bug, but it has a bunch of other problems (notably fetch-pack won't run as v2, but some other tests I think also depend on v0's reachability rules, which v2 is documented not to enforce).
Quoted 4 lines
Quoted 1 line
I think a global test mode for it would be a very good idea.
Yeah, but somebody needs to pick through the dozens of false positives for it to be useful.
Here's that test mode. As noted in 3/3 there may be more bugs revealed by this, but let's first start by marking where the behavior differs.
Ævar Arnfjörð Bjarmason (3):
tests: add a special setup where for protocol.version
tests: mark tests broken under GIT_TEST_PROTOCOL_VERSION=1
tests: mark tests broken under GIT_TEST_PROTOCOL_VERSION=2
protocol.c | 13 ++++++++++++- t/README | 4 ++++ t/t0410-partial-clone.sh | 1 + t/t5400-send-pack.sh | 2 +- t/t5500-fetch-pack.sh | 4 +++- t/t5503-tagfollow.sh | 8 ++++---- t/t5512-ls-remote.sh | 8 ++++---- t/t5515-fetch-merge-logic.sh | 1 + t/t5516-fetch-push.sh | 4 +++- t/t5537-fetch-shallow.sh | 3 ++- t/t5552-skipping-fetch-negotiator.sh | 1 + t/t5601-clone.sh | 1 + t/t5616-partial-clone.sh | 3 ++- t/t5700-protocol-v1.sh | 1 + t/t5702-protocol-v2.sh | 1 + t/t7406-submodule-update.sh | 3 ++- 16 files changed, 43 insertions(+), 15 deletions(-)
Signature · 1 line
2.20.0.405.gbc1bbc6f85