Skip to content

drm/i915/icl: Fix TypeC Legacy HPD handling

Imre Deak intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 6 repliesIn review
  2. v13 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915/icl: Add a debug print for TypeC port disconnectiondrivers/gpu/drm/i915/intel_dp.c+24 -100 replies
2/4drm/i915/bios: Parse the VBT TypeC and Thunderbolt port flagsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_bios.c+11 -21 reply
3/4drm/i915/icl: Fix HPD handling for TypeC legacy portsdrivers/gpu/drm/i915/intel_ddi.c drivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+73 -163 replies
4/4drm/i915/icl: Add fallback detection method for TypeC legacy portsdrivers/gpu/drm/i915/intel_dp.c+8 -21 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchRodrigo ViviMika Kahola
1/4R-b
2/4R-b
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] drm/i915/icl: Fix TypeC Legacy HPD handling

This is v2 of [1]. The changes in v2:
- Use VBT for detecting legacy ports. There was already a flag for this in VBT, I just missed it. Thanks for Siva for pointing that out. With that we have a detection that works all the time for DP ports as well.
- Remove a redundant special casing of legacy ports during disconnection in patch 3.

[1] https://patchwork.freedesktop.org/series/54017/

Cc Paulo Zanoni <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc José Roberto de Souza <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Sivakumar Thulasimani <[email protected]>

Imre Deak (4):
drm/i915/icl: Add a debug print for TypeC port disconnection drm/i915/bios: Parse the VBT TypeC and Thunderbolt port flags drm/i915/icl: Fix HPD handling for TypeC legacy ports drm/i915/icl: Add fallback detection method for TypeC legacy ports

 drivers/gpu/drm/i915/i915_drv.h   |  2 ++
 drivers/gpu/drm/i915/intel_bios.c | 11 +++++--
 drivers/gpu/drm/i915/intel_ddi.c  | 63 ++++++++++++++++++++++++++++++++++-----
 drivers/gpu/drm/i915/intel_dp.c   | 61 ++++++++++++++++++++++++++-----------
 drivers/gpu/drm/i915/intel_drv.h  |  5 +++-
 5 files changed, 114 insertions(+), 28 deletions(-)
Signature · 6 lines
2.13.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx