Skip to content

mm: PG_reserved cleanups and documentation

David Hildenbrand linux-arm-kernel linux-mediatek linux-mm linux-riscv linux-s390 linuxppc-dev lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 9 repliesIn review
  2. v19 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Minor speeling errors in "mm: better document PG_reserved" fixed
- Added ACKs

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9agp: efficeon: no need to set PG_reserved on GATT tablesdrivers/char/agp/efficeon-agp.c+0 -20 replies
2/9s390/vdso: don't clear PG_reservedarch/s390/kernel/vdso.c+0 -20 replies
3/9powerpc/vdso: don't clear PG_reservedarch/powerpc/kernel/vdso.c+0 -20 replies
4/9riscv/vdso: don't clear PG_reservedarch/riscv/kernel/vdso.c+0 -11 reply
5/9m68k/mm: use __ClearPageReserved()arch/m68k/mm/memory.c+1 -11 reply
6/9arm64: kexec: no need to ClearPageReserved()arch/arm64/kernel/machine_kexec.c+0 -12 replies
7/9arm64: kdump: No need to mark crashkernel pages manually PG_reservedarch/arm64/kernel/machine_kexec.c arch/arm64/mm/init.c+1 -282 replies
8/9ia64: perfmon: Don't mark buffer pages as PG_reservedarch/ia64/kernel/perfmon.c+4 -550 replies
9/9mm: better document PG_reservedinclude/linux/page-flags.h+31 -20 replies

Reviews trailers per patch

5 of 9 patches have a Reviewed-by or Acked-by.

PatchMichael EllermanPalmer DabbeltJames MorseMatthias BruggerGeert UytterhoevenBhupesh SharmaChristoph HellwigCatalin Marinas
1/9
2/9
3/9A-b
4/9A-b R-b
5/9A-b
6/9A-b R-b A-b
7/9R-b R-b A-b
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 8 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/9] mm: PG_reserved cleanups and documentation

Nothing major changed since the last version. I would be happy about additional ACKs. If there are no further comments, can this go via the mm-tree in one chunk?

I was recently going over all users of PG_reserved. Short story: it is difficult and sometimes not really clear if setting/checking for PG_reserved is only a relict from the past. Easy to break things. I guess I now have a pretty good idea wh things are like that nowadays and how they evolved.

I had way more cleanups in this series inititally,
but some architectures take PG_reserved as a way to apply a different caching strategy (for MMIO pages). So I decided to only include the most obvious changes (that are less likely to break something). So the big chunk of manual SetPageReserved users are MMIO/DMA related things on device buffers.

Most notably, for device memory we will hopefully soon stop setting PG_reserved. Then the documentation has to be updated.

v1 -> v2:
- Minor speeling errors in "mm: better document PG_reserved" fixed
- Added ACKs

RFC -> v1:
- Add more details to "mm: better document PG_reserved"
- Add "arm64: kdump: No need to mark crashkernel pages manually PG_reserved"
- Add "ia64: perfmon: Don't mark buffer pages as PG_reserved"
- Added ACKs

David Hildenbrand (9):
agp: efficeon: no need to set PG_reserved on GATT tables s390/vdso: don't clear PG_reserved
powerpc/vdso: don't clear PG_reserved
riscv/vdso: don't clear PG_reserved
m68k/mm: use __ClearPageReserved()
arm64: kexec: no need to ClearPageReserved()
arm64: kdump: No need to mark crashkernel pages manually PG_reserved
ia64: perfmon: Don't mark buffer pages as PG_reserved
mm: better document PG_reserved

 arch/arm64/kernel/machine_kexec.c |  3 +-
 arch/arm64/mm/init.c              | 27 --------------
 arch/ia64/kernel/perfmon.c        | 59 +++----------------------------
 arch/m68k/mm/memory.c             |  2 +-
 arch/powerpc/kernel/vdso.c        |  2 --
 arch/riscv/kernel/vdso.c          |  1 -
 arch/s390/kernel/vdso.c           |  2 --
 drivers/char/agp/efficeon-agp.c   |  2 --
 include/linux/page-flags.h        | 33 +++++++++++++++--
 9 files changed, 37 insertions(+), 94 deletions(-)
Signature · 1 line
2.17.2