Skip to content

crypto: authenc - fix key parsing

Eric Biggers linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3crypto: authenc - fix parsing key with misaligned rta_lencrypto/authenc.c+11 -30 replies
2/3crypto: bcm - convert to use crypto_authenc_extractkeys()drivers/crypto/Kconfig drivers/crypto/bcm/cipher.c+14 -310 replies
3/3crypto: ccree - convert to use crypto_authenc_extractkeys()drivers/crypto/ccree/cc_aead.c+19 -210 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] crypto: authenc - fix key parsing

Fix incorrect validation of the key passed to "authenc" AEADs that allowed crashing the kernel via AF_ALG. The real fix is in patch 1, but two drivers had to be converted to use crypto_authenc_extractkeys() too.

Please note: for the bcm and ccree driver changes I haven't re-run the self-tests, as I don't have that hardware. Please do so if you can.

Eric Biggers (3):
crypto: authenc - fix parsing key with misaligned rta_len
crypto: bcm - convert to use crypto_authenc_extractkeys()
crypto: ccree - convert to use crypto_authenc_extractkeys()

 crypto/authenc.c               | 14 ++++++++---
 drivers/crypto/Kconfig         |  1 +
 drivers/crypto/bcm/cipher.c    | 44 ++++++++++------------------------
 drivers/crypto/ccree/cc_aead.c | 40 +++++++++++++++----------------
 4 files changed, 44 insertions(+), 55 deletions(-)
Signature · 1 line
2.19.2