btrfs-progs: check: Fix
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest13 patches 1 replyIn review
Patches in v1 No applies recorded yet
Reviews trailers per patch
7 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Qu Wenruo |
|---|---|
| 1/13 | R-b |
| 2/13 | R-b |
| 3/13 | R-b |
| 4/13 | R-b |
| 5/13 | R-b |
| 6/13 | R-b |
| 7/13 | R-b |
| 8/13 | |
| 9/13 | |
| 10/13 | |
| 11/13 | |
| 12/13 | |
| 13/13 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/13] btrfs-progs: check: Fix
This patchset can be fetched from github:
https://github.com/adam900710/btrfs-progs/tree/file_extents_fixes
The base commit is devel branch:
commit e1e7519c2d225554004b55a5c19eb196db92285a (david/devel)
Author: Qu Wenruo <[email protected]> Date: Thu Oct 25 15:35:47 2018 +0800
btrfs-progs: tests: check: Make 026-bad-dir-item-name verify if btrfs-check can also repair
Just remove the customized 'test.sh', then generic fsck test will do the check-repair-check.
Originally for fsck-tests/001-bad-file-extent-bytenr we're going to fix it by resetting the corrupted file extent, using the disk bytenr from data backref.
However in real world, extent tree is the most fragile one while fs tree is more reliable.
This means fixing using extent tree can sometimes be more dangerous, and causing extra corruption from repair.
Further more, that test case is a big blockage for any later modification on file extent repair code.
So the goal of this patchset is to change the repair behavior from rebuilding file extents using data backref, to dropping invalid file extents and modify extent tree.
Despite above change, we have some small bug fixes for:
- False alert for file extents gap
- Bad data backref -> file extent search in repair mode
The patchset is mostly from Fujitsu guys (Lu, Su Yue, Su Yanjun). My work here is:
- Solve rebase conflicts
Mostly with DIR_ITEM hash mismatch patchset
- Commit message/comment update
Make them a little more reader friendly
- Reorder the patchset
Make small fixes first.
Lu Fengqi (2):
btrfs-progs: lowmem: fix false alert about the existence of gaps in
the check_file_extent
btrfs-progs: tests: add case for inode lose one file extent
Su Yanjun (4):
btrfs-progs: Revert "btrfs-progs: Add repair and report function for
orphan file extent."
btrfs-progs: Revert "btrfs-progs: Record orphan data extent ref to
corresponding root."
btrfs-progs: check: fix wrong @offset used in find_possible_backrefs()
btrfs-progs: check: Delete file extent item with unaligned disk bytenr
Su Yue (7):
btrfs-progs: lowmem: add argument path to punch_extent_hole()
btrfs-progs: lowmem: move nbytes check before isize check
btrfs-progs: lowmem: fix false alert if extent item has been repaired
btrfs-progs: lowmem: check unaligned disk_bytenr for extent_data
btrfs-progs: lowmem: rename delete_extent_tree_item() to delete_item()
btrfs-progs: lowmem: delete unaligned bytes extent data under repair
btrfs-progs: fsck-test: enable lowmem repair for case 001
check/main.c | 584 +++++++++++------- check/mode-lowmem.c | 293 +++++---- check/mode-original.h | 30 +- ctree.h | 10 +- disk-io.c | 2 +- .../.lowmem_repairable | 0 .../.lowmem_repairable | 0 .../default_case.img | Bin 0 -> 3072 bytes 8 files changed, 543 insertions(+), 376 deletions(-) create mode 100644 tests/fsck-tests/001-bad-file-extent-bytenr/.lowmem_repairable create mode 100644 tests/fsck-tests/038-missing-one-file-extent/.lowmem_repairable create mode 100644 tests/fsck-tests/038-missing-one-file-extent/default_case.img
Signature · 1 line
2.20.0