Fix strncpy() warnings for GCC8 new -Wstringop-truncation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest5 patches 0 repliesNew
- v45 patches 5 repliesSuperseded
- v35 patches 18 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 15 replies | Superseded |
Changes in v5 from the cover letter
- fixed some checkpatch errors/warnings reported by patchew
- commented checkpatch errors/warnings false positives
- added Reviewed-by
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | qemu/compiler: Define QEMU_NONSTRINGinclude/ | +15 | 0 replies | |
| 2/5 | block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arraysblock/ | +1 | 0 replies | |
| 3/5 | hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrayshw/ include/ | +16 | 0 replies | |
| 4/5 | migration: Fix stringop-truncation warningmigration/ | +1 | 0 replies | |
| 5/5 | migration: Use strnlen() for fixed-size stringmigration/ | +13 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Michael S. Tsirkin | Richard Henderson | Thomas Huth | Igor Mammedov | Dr. David Alan Gilbert | Philippe Mathieu-Daudé |
|---|---|---|---|---|---|---|---|
| 1/5 | R-b | R-b | R-b | R-b | |||
| 2/5 | R-b | R-b | |||||
| 3/5 | R-b | R-b | |||||
| 4/5 | R-b | R-b | R-b | ||||
| 5/5 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.
Cover letter [Qemu-devel] [PATCH v5 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation
GCC 8 new warning prevents builds to success since quite some time. First report on the mailing list is in July 2018:
https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html
Since v4:
- fixed some checkpatch errors/warnings reported by patchew
- commented checkpatch errors/warnings false positives
- added Reviewed-by
Now this series is fully reviewed.
Since v3:
- patch 1: make sens of description (eblake)
- patch 2: append QEMU_NONSTRING instead of prepending it (mst)
- patch 3: rebased (imammedo), intented
- patch 4: replaced by Marc-André first attempt, improved doc
- patch 5: add assert() and NUL-terminate the buffer (mst)
Various intents has been sent to fix this:
- Incorrectly using g_strlcpy()
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03705.html
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03706.html
- Using assert() and strpadcpy()
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html
This was the approch taken by the previous v2:
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04405.html
- Use #pragma GCC diagnostic ignored "-Wstringop-truncation"
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- adding an inline wrapper with said pragma in there
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- -Wno-stringop-truncation is the makefile
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html
- Use the 'nonstring' attribute
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04493.html
This series add the QEMU_NONSTRING definition and use it.
Regards,
Phil.
v4: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg06175.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04596.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04405.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html
Marc-André Lureau (1):
migration: Fix stringop-truncation warning
Philippe Mathieu-Daudé (4):
qemu/compiler: Define QEMU_NONSTRING
block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays
migration: Use strnlen() for fixed-size string
block/sheepdog.c | 2 +- hw/acpi/core.c | 12 ++++++++---- include/hw/acpi/acpi-defs.h | 13 ++++++++----- include/qemu/compiler.h | 15 +++++++++++++++ migration/global_state.c | 15 ++++++++++++++- 5 files changed, 46 insertions(+), 11 deletions(-)
Signature · 1 line
2.17.2