Skip to content

Fix & improve icon display on GTK and SDL frontends

Daniel P. Berrangé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Add a 'regenerate' make target in ui/icons to rebuild icons from SVG using inkscape.
- Allow use of SDL_Image to be disabled with --enable-sdl-image configure arg
- Reduce number of conditionals in SDL code
- Fix variable name typo in SDL code

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ui: install logo icons to $prefix/share/iconsMakefile configure pc-bios/qemu-icon.bmp +13 more+38 -232 replies
2/3ui: fix icon display for GTK frontend under GNOME Shell with WaylandMakefile configure ui/gtk.c +1 more+14 -00 replies
3/3sdl: add support for high resolution window iconconfigure include/ui/sdl2.h ui/sdl2.c+58 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] Fix & improve icon display on GTK and SDL frontends

This series improves the GTK and SDL frontends so that they display the high quality QEMU logo.

Changed in v2:

- Add a 'regenerate' make target in ui/icons to rebuild icons from SVG using inkscape.
- Allow use of SDL_Image to be disabled with --enable-sdl-image configure arg
- Reduce number of conditionals in SDL code
- Fix variable name typo in SDL code

Daniel P. Berrangé (3):
ui: install logo icons to $prefix/share/icons
ui: fix icon display for GTK frontend under GNOME Shell with Wayland
sdl: add support for high resolution window icon

 Makefile                                      |  16 +++++-
 configure                                     |  47 ++++++++++++++++++
 include/ui/sdl2.h                             |   3 ++
 pc-bios/qemu-icon.bmp                         | Bin 630 -> 0 bytes
 ui/gtk.c                                      |  18 +++----
 ui/icons/Makefile                             |  13 +++++
 .../icons/qemu.svg                            |   0
 ui/icons/qemu_128x128.png                     | Bin 0 -> 8286 bytes
 ui/icons/qemu_16x16.png                       | Bin 0 -> 765 bytes
 ui/icons/qemu_24x24.png                       | Bin 0 -> 1201 bytes
 ui/icons/qemu_256x256.png                     | Bin 0 -> 17572 bytes
 ui/icons/qemu_32x32.bmp                       | Bin 0 -> 4234 bytes
 ui/icons/qemu_32x32.png                       | Bin 0 -> 1696 bytes
 ui/icons/qemu_48x48.png                       | Bin 0 -> 2694 bytes
 ui/icons/qemu_512x512.png                     | Bin 0 -> 38007 bytes
 ui/icons/qemu_64x64.png                       | Bin 0 -> 3807 bytes
 ui/qemu.desktop                               |   8 +++
 ui/sdl2.c                                     |  22 ++++----
 18 files changed, 104 insertions(+), 23 deletions(-)
 delete mode 100644 pc-bios/qemu-icon.bmp
 create mode 100644 ui/icons/Makefile
 rename pc-bios/qemu_logo_no_text.svg => ui/icons/qemu.svg (100%)
 create mode 100644 ui/icons/qemu_128x128.png
 create mode 100644 ui/icons/qemu_16x16.png
 create mode 100644 ui/icons/qemu_24x24.png
 create mode 100644 ui/icons/qemu_256x256.png
 create mode 100644 ui/icons/qemu_32x32.bmp
 create mode 100644 ui/icons/qemu_32x32.png
 create mode 100644 ui/icons/qemu_48x48.png
 create mode 100644 ui/icons/qemu_512x512.png
 create mode 100644 ui/icons/qemu_64x64.png
 create mode 100644 ui/qemu.desktop
Signature · 1 line
2.19.2