nbd-client: drop extra error noise
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest3 patches 3 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | nbd: publish _lookup functionsinclude/ nbd/ | +5 | 0 replies | |
| 2/3 | nbd/client: Trace all server option error messagesnbd/ nbd/ | +3 | 1 reply | |
| 3/3 | block/nbd-client: use traces instead of noisy error_report_errblock/ block/ tests/ | +23 | 0 replies |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Vladimir Sementsov-Ogievskiy |
|---|---|---|
| 1/3 | R-b | |
| 2/3 | R-b | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/3] nbd-client: drop extra error noise
This is a counter-proposal to Vladimir's initial post for reducing the noise in iotest 083. The difference is that I dropped error_get_hint, since I couldn't find any useful hint to be traced during transmission phase in the first place, and instead added a trace message for the one place where we do set hints during handshaking phase.
Eric Blake (1):
nbd/client: Trace all server option error messages
Vladimir Sementsov-Ogievskiy (2):
nbd: publish _lookup functions
block/nbd-client: use traces instead of noisy error_report_err
include/block/nbd.h | 5 +++++ nbd/nbd-internal.h | 5 ----- block/nbd-client.c | 23 +++++++++++++++++++---- nbd/client.c | 2 ++ block/trace-events | 4 ++++ nbd/trace-events | 1 + tests/qemu-iotests/083.out | 28 ---------------------------- 7 files changed, 31 insertions(+), 37 deletions(-)
Signature · 1 line
2.17.2