Skip to content

PCI: DWC/Keystone: MSI configuration cleanup

Kishon Vijay Abraham I linux-arm-kernel linux-pci lkml 5 versions – Applied

Status from this message: Applied to pci/keystone, aiming for v5.2 unless something goes

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 4 repliesApplied
  2. v49 patches 8 repliesSuperseded
  3. v39 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v29 patches14 repliesSuperseded
v110 patches4 repliesSuperseded

Changes in v5 from the cover letter

*) Removed legacy interrupt cleanup patch which uses hierarchy IRQ
domain since TI platform uses edge interrupt for legacy interrupt. This will be deferred till I get more details from HW team.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/8PCI: keystone: Cleanup interrupt related macrosdrivers/pci/controller/dwc/pci-keystone.c+13 -130 replies
2/8PCI: keystone: Add separate functions for configuring MSI and legacy interruptdrivers/pci/controller/dwc/pci-keystone.c+89 -920 replies
3/8PCI: keystone: Use hwirq to get the MSI IRQ number offsetdrivers/pci/controller/dwc/pci-keystone.c+13 -110 replies
4/8PCI: keystone: Cleanup ks_pcie_msi_irq_handlerdrivers/pci/controller/dwc/pci-keystone.c+28 -360 replies
5/8PCI: dwc: Add support to use non default msi_irq_chipdrivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+5 -10 replies
6/8PCI: keystone: Use Keystone specific msi_irq_chipdrivers/pci/controller/dwc/pci-keystone.c drivers/pci/controller/dwc/pcie-designware-host.c+74 -270 replies
7/8PCI: dwc: Remove Keystone specific dw_pcie_host_opsdrivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+14 -410 replies
8/8PCI: dwc: Do not write to MSI control registers if the platform doesn't use itdrivers/pci/controller/dwc/pcie-designware-host.c+13 -112 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/8] PCI: DWC/Keystone: MSI configuration cleanup

This series tries to address the comments discussed in [1] w.r.t removing Keystone specific callbacks defined in dw_pcie_host_ops.

This series also tries to cleanup the Keystone interrupt handling part.

Changes from v4:
*) Removed legacy interrupt cleanup patch which uses hierarchy IRQ
domain since TI platform uses edge interrupt for legacy interrupt. This will be deferred till I get more details from HW team.

Changes from v3:
*) Uses hierarchy IRQ domain for legacy interrupts since there is 1:1
mapping between legacy interrupt and GIC IRQ.
(MSI still depends on the order of IRQs populated in dt).

Changes from v2:
*) Removed patch that modifies ks_pcie_legacy_irq_handler() to check the
IRQ_STATUS of INTA/B/C/D. Lorenzo's comment to create a matrix LinuxIRQ x INTx will be added in AM654x PCIe support series
*) ks_pcie_legacy_irq_handler() is made to use hwirq to get IRQ offset
instead of virq.
*) default msi_irq_chip is assigned in dw_pcie_host_init() once keystone
assigns its msi_irq_chip
*) Fixed other minor comments from Lorenzo and Bjorn

Changes from v1:
*) Removed "PCI: keystone: Use "dummy_irq_chip" instead of new irqchip for legacy interrupt handling" from the patch series. It should be handled differently.

*) Added Gustavo's ACKed by and fixed a commit message.

[1] -> https://patchwork.kernel.org/patch/10681587/

Kishon Vijay Abraham I (8):
PCI: keystone: Cleanup interrupt related macros
PCI: keystone: Add separate functions for configuring MSI and legacy
interrupt
PCI: keystone: Use hwirq to get the MSI IRQ number offset
PCI: keystone: Cleanup ks_pcie_msi_irq_handler
PCI: dwc: Add support to use non default msi_irq_chip
PCI: keystone: Use Keystone specific msi_irq_chip
PCI: dwc: Remove Keystone specific dw_pcie_host_ops
PCI: dwc: Do not write to MSI control registers if the platform
doesn't use it

 drivers/pci/controller/dwc/pci-keystone.c     | 365 ++++++++++--------
 .../pci/controller/dwc/pcie-designware-host.c |  78 ++--
 drivers/pci/controller/dwc/pcie-designware.h  |   6 +-
 3 files changed, 233 insertions(+), 216 deletions(-)
Signature · 1 line
2.17.1