Skip to content

A2DP: Fix endianity and define new A2DP codecs

Pali Rohár linux-bluetooth 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 2 repliesIn review
  2. v110 patches 2 repliesSuperseded

Changes in v2 from the cover letter

* Fix style issues

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10avinfo: Fix buffer overflow when parsing broken/malicious datatools/avinfo.c+72 -200 replies
2/10avinfo: Show Vendor Specific Datatools/avinfo.c+6 -10 replies
3/10a2dp-codecs: Add SBC prefix for MIN/MAX_BITPOOL constantsandroid/hal-audio-sbc.c profiles/audio/a2dp-codecs.h+8 -80 replies
4/10a2dp-codecs: Fix codec id for ATRACprofiles/audio/a2dp-codecs.h+1 -10 replies
5/10a2dp-codecs & avinfo: Fix parsing MPEG bit rate valuesprofiles/audio/a2dp-codecs.h tools/avinfo.c+176 -520 replies
6/10a2dp-codecs: Define a2dp_vendor_codec_t struct in endian neutral wayandroid/a2dp.c android/avdtp.c android/hal-audio-aptx.c +3 more+43 -260 replies
7/10a2dp-codecs: Add needed includes and properly check for endian macrosprofiles/audio/a2dp-codecs.h+7 -20 replies
8/10a2dp-codecs: Properly define macros and struct for LDAC codecprofiles/audio/a2dp-codecs.h tools/avinfo.c+19 -120 replies
9/10a2dp-codecs: Add macros and structures for new codecsprofiles/audio/a2dp-codecs.h+120 -00 replies
10/10avinfo: Parse new A2DP codecstools/avinfo.c+144 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/10] A2DP: Fix endianity and define new A2DP codecs

This patch series try to fix endianity problems in a2dp-codecs.h file, then fixes parsing MPEG bit rate values, extend a2dp-codecs.h file for new A2DP codecs FastStream, aptX Low Latency, aptX HD and finally adds support for parsing information about FastStream, aptX Low Latency, aptX HD and LDAC codecs in avinfo utility.

Changes since v1:
* Fix style issues

Pali Rohár (10):
avinfo: Fix buffer overflow when parsing broken/malicious data
avinfo: Show Vendor Specific Data
a2dp-codecs: Add SBC prefix for MIN/MAX_BITPOOL constants
a2dp-codecs: Fix codec id for ATRAC
a2dp-codecs & avinfo: Fix parsing MPEG bit rate values
a2dp-codecs: Define a2dp_vendor_codec_t struct in endian neutral way
a2dp-codecs: Add needed includes and properly check for endian macros
a2dp-codecs: Properly define macros and struct for LDAC codec
a2dp-codecs: Add macros and structures for new codecs
avinfo: Parse new A2DP codecs

 android/a2dp.c               |   8 +-
 android/avdtp.c              |   6 +-
 android/hal-audio-aptx.c     |  18 +-
 android/hal-audio-sbc.c      |  12 +-
 profiles/audio/a2dp-codecs.h | 267 ++++++++++++++++++++++++++----
 profiles/audio/a2dp.c        |   9 +-
 tools/avinfo.c               | 380 ++++++++++++++++++++++++++++++++++++-------
 7 files changed, 586 insertions(+), 114 deletions(-)
Signature · 1 line
2.11.0