Skip to content

DRBD updates for 4.21

Lars Ellenberg drbd-dev linux-block lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17drbd: narrow rcu_read_lock in drbd_sync_handshakedrivers/block/drbd/drbd_receiver.c+6 -50 replies
2/17drbd: must not use connection after kref_put(&connection->kref)drivers/block/drbd/drbd_state.c+1 -20 replies
3/17drbd: centralize printk reporting of new size into drbd_set_my_capacity()drivers/block/drbd/drbd_int.h drivers/block/drbd/drbd_main.c drivers/block/drbd/drbd_nl.c+17 -110 replies
4/17drbd: ignore "all zero" peer volume sizes in handshakedrivers/block/drbd/drbd_receiver.c+30 -30 replies
5/17drbd: disconnect, if the wrong UUIDs are attached on a connected peerdrivers/block/drbd/drbd_receiver.c+1 -10 replies
6/17drbd: fix confusing error message during attachdrivers/block/drbd/drbd_nl.c+44 -50 replies
7/17drbd: attach on connected diskless peer must not shrink a consistent devicedrivers/block/drbd/drbd_receiver.c+6 -50 replies
8/17drbd: reject attach of unsuitable uuids even if connecteddrivers/block/drbd/drbd_nl.c drivers/block/drbd/drbd_receiver.c+22 -30 replies
9/17drbd: fix comment typosdrivers/block/drbd/drbd_receiver.c drivers/block/drbd/drbd_state.c+2 -20 replies
10/17drbd: do not block when adjusting "disk-options" while IO is frozendrivers/block/drbd/drbd_nl.c+29 -80 replies
11/17drbd: avoid spurious self-outdating with concurrent disconnect / downdrivers/block/drbd/drbd_nl.c+7 -00 replies
12/17drbd: fix print_st_err()'s prototype to match the definitiondrivers/block/drbd/drbd_state.h+1 -10 replies
13/17drbd: don't retry connection if peers do not agree on "authentication" settingsdrivers/block/drbd/drbd_receiver.c+1 -10 replies
14/17drbd: skip spurious timeout (ping-timeo) when failing promotedrivers/block/drbd/drbd_nl.c+8 -70 replies
15/17drbd: introduce P_ZEROES (REQ_OP_WRITE_ZEROES on the "wire")drivers/block/drbd/drbd_debugfs.c drivers/block/drbd/drbd_int.h drivers/block/drbd/drbd_main.c +7 more+252 -310 replies
16/17drbd: Avoid Clang warning about pointless switch statmentinclude/linux/genl_magic_struct.h+4 -10 replies
17/17drbd: Change drbd_request_detach_interruptible's return type to intdrivers/block/drbd/drbd_state.c drivers/block/drbd/drbd_state.h+3 -60 replies

Reviews trailers per patch

2 of 17 patches have a Reviewed-by or Acked-by.

PatchLars EllenbergNick Desaulniers
1/17R-b
2/17
3/17
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/17] DRBD updates for 4.21

Hi Jens,

I hope this is not too late for your for-4.21 branch.

These are all from last April or even older,
I was convinced we sent these for 4.19 already.
But we didn't :-(

The interesting new feature is "introduce P_ZEROES", which is replacing 45c21793a660 drbd: implement REQ_OP_WRITE_ZEROES
because that led to "full allocation" for fstrim on dm-thin or similar, which is certainly not the intended behavior.

Patch 3 to 8 help with recovery from odd corner cases in multiple error scenarios in a cluster, potentially after some admin already "tried things".

All others are sufficiently simple and supposedly "obvious".

Lars Ellenberg (13):
drbd: must not use connection after kref_put(&connection->kref)
drbd: centralize printk reporting of new size into drbd_set_my_capacity()
drbd: ignore "all zero" peer volume sizes in handshake
drbd: disconnect, if the wrong UUIDs are attached on a connected peer
drbd: fix confusing error message during attach
drbd: attach on connected diskless peer must not shrink a consistent device
drbd: reject attach of unsuitable uuids even if connected
drbd: fix comment typos
drbd: do not block when adjusting "disk-options" while IO is frozen
drbd: avoid spurious self-outdating with concurrent disconnect / down
drbd: don't retry connection if peers do not agree on "authentication" settings
drbd: skip spurious timeout (ping-timeo) when failing promote
drbd: introduce P_ZEROES (REQ_OP_WRITE_ZEROES on the "wire")

Luc Van Oostenryck (1):
drbd: fix print_st_err()'s prototype to match the definition

Nathan Chancellor (2):
drbd: Avoid Clang warning about pointless switch statment
drbd: Change drbd_request_detach_interruptible's return type to int

Roland Kammerer (1):
drbd: narrow rcu_read_lock in drbd_sync_handshake

 drivers/block/drbd/drbd_debugfs.c  |   2 +
 drivers/block/drbd/drbd_int.h      |  19 +--
 drivers/block/drbd/drbd_main.c     |  28 +++-
 drivers/block/drbd/drbd_nl.c       | 133 ++++++++++++---
 drivers/block/drbd/drbd_protocol.h |  47 ++++++
 drivers/block/drbd/drbd_receiver.c | 251 +++++++++++++++++++++++++----
 drivers/block/drbd/drbd_req.c      |  19 +--
 drivers/block/drbd/drbd_req.h      |   2 +
 drivers/block/drbd/drbd_state.c    |  11 +-
 drivers/block/drbd/drbd_state.h    |   5 +-
 drivers/block/drbd/drbd_worker.c   |   2 +-
 include/linux/drbd.h               |   2 +-
 include/linux/genl_magic_struct.h  |   5 +-
 13 files changed, 434 insertions(+), 92 deletions(-)
Signature · 1 line
2.17.1