Skip to content

dmg: fixing reading in dmg

yuchenlin qemu-devel 3 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyApplied
  2. v23 patches 10 repliesSuperseded
  3. v11 patch 4 repliesSuperseded

Changes in v3 from the cover letter

* fix potential overflow (Thanks Stefan)
* add Reviewed tag in patch 2 and 3

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3dmg: fix binary searchblock/dmg.c+7 -30 replies
2/3dmg: use enumeration type instead of hard coding numberblock/dmg.c+2 -20 replies
3/3dmg: don't skip zero chunkblock/dmg.c+12 -70 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchJulio FaraccoStefan Hajnoczi
1/3
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/3] dmg: fixing reading in dmg

There are two bugs in dmg reading.

First, it may hang in binary search. this problem is solved by patch 1. Second, because of lacking zero chunk table, reading zero sector will return EIO. this problem is solved by patch 2 and 3.

Thanks

v2 -> v3:
* fix potential overflow (Thanks Stefan)
* add Reviewed tag in patch 2 and 3

v1 -> v2:
* fix typos in patch 1
* add patch 2 and patch 3

yuchenlin (3):
dmg: fix binary search
dmg: use enumeration type instead of hard coding number
dmg: don't skip zero chunk

 block/dmg.c | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1