core/sdk: fix relative symlinks in generated tarball (branch yem/sdk)
Get series with b4
b4 am 20181222185413.GW24194@scaerVersions newest first
- v1 Latest0 of 2 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 2 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/2] core/sdk: fix relative symlinks in generated tarball (branch yem/sdk)
Joel, All,
On 2018-12-22 11:21 -0700, Joel Carlson spake thusly:
Quoted 1 line · Yann E. MORIN
[--SNIP--]
Quoted 4 lines
Quoted 3 lines
I did nt see Thomas' reply to the iptables patch before I replied to your eudev one. It turns out we basically said exactly the same thing:
this is not the correct solution.My apologies on submitting a bad patch.
Hey, no worries! :-) That's what reviews are for.
Quoted 8 lines
Quoted 8 lines
if it is a symlink:
if is not below staging/:
check and fix it
else if it is below staging/{lib,usr/lib,usr/include}:
check and fix it
else
ignore it
Quoted 7 lines
Quoted 2 lines
I can try to look into fixing that in my series. Is enabling eudev and/or iptables enough to echibit the problem?
That is a better solution. And yes, with the previous sdk fixes applied, just enabling eudev and/or iptables and then trying to 'make sdk' would error out because of the symlink path being outside of staging.
Yeah, I eventually managed to reproduce the issue, indeed. so I submitted v3 of the series. Thanks! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'