Skip to content

drm: minimize drmP.h dependencies

Sam Ravnborg dri-devel intel-gfx linux-renesas-soc lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 4 repliesIn review
  2. v56 patches 6 repliesSuperseded
  3. v48 patches 7 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v312 patches8 repliesSuperseded
v214 patches16 repliesSuperseded
v17 patches8 repliesApplied

Changes in v6 from the cover letter

- include fixes to vboxvideo (Daniel)
- include i915 build fixes
- revised/new rcar-du patch (lots of new build failures popped up)
- split updates to drm/*.c file to dedicated patch,
to make the final removal patch slimmer

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging/vboxvideo: prepare for drmP.h removal from drm_modeset_helper.hdrivers/staging/vboxvideo/vbox_drv.c drivers/staging/vboxvideo/vbox_fb.c drivers/staging/vboxvideo/vbox_mode.c+19 -102 replies
2/5drm/i915: prepare for drmP.h removal from drm_modeset_helper.hdrivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/intel_atomic.c drivers/gpu/drm/i915/intel_atomic_plane.c +2 more+28 -161 reply
3/5drm/rcar-du: prepare for drmP.h removal from drm_modeset_helper.hdrivers/gpu/drm/rcar-du/rcar_du_crtc.c drivers/gpu/drm/rcar-du/rcar_du_drv.c drivers/gpu/drm/rcar-du/rcar_du_kms.c +2 more+9 -00 replies
4/5drm: prepare for drmP.h removal from drm_modeset_helper.hdrivers/gpu/drm/drm_damage_helper.c drivers/gpu/drm/drm_modeset_helper.c+3 -00 replies
5/5drm: remove drmP.h from drm_modeset_helper.hinclude/drm/drm_modeset_helper.h+5 -10 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchLaurent PinchartJani NikulaGreg Kroah-Hartman
1/5A-b
2/5A-b
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/5] drm: minimize drmP.h dependencies

Updated patchset, with merged patches removed, new patches added.

Quoted 1 line

From the original mail:

- drmP.h is now stripped down to include files and forward declarations.
- All header files in include/drm/ no longer include drmP.h.

The series was made on top of drm-misc-next:
f1a2a540c86441016ce3dff6590b7a09080871de ("video/hdmi: Add an enum for HDMI packet types")

Build tested using arm and x86, ia64, alpha, sparc32, sparc64 Included staging/vboxvideo in the build test - which revealed the build issues Daniel had identifed

This series include fixes to i915 as it looks in drm-misc. This series also include fixes to stagin/vboxvideo, which I expect to be committet to drm-misc due to the final patch (drmP.h removal from drm_modeset_helper.h) depending on this patch.

Daniel - thanks for being paitent and applying this piecemal.

Sam
v6:
- include fixes to vboxvideo (Daniel)
- include i915 build fixes
- revised/new rcar-du patch (lots of new build failures popped up)
- split updates to drm/*.c file to dedicated patch,
to make the final removal patch slimmer

v5:
- Rebased on top of drm-misc-next and dropped patches already merged
- Sorted list of include files where they are touched (Laurent)
- Collected ack's, reviewed by's

v4:
- Rebased on top of drm-misc-next and dropped patches already merged
- Include build test of kirin (Daniel)
- Plug drm_util.h into drm-internals.rst (Daniel)
- Fix kernel-doc syntax in drm_util.h (Daniel)
- Split removal of drmP.h from drm_modeset_helper.h
in smaller patches, to ease the merge process

v3:
- Added Acks/Reviewed annotations (thanks!)
- Add forward of drm_gem_object to drm_framebuffer.h (Noralf)
- Drop "drm: move DRM_IF_VERSION to drm_internal.h" as it is applied to drm-misc
- Drop "drm: make drm_file.h self contained" as Jan made a similar patch that was appleid to drm-misc
- Rebased on top of drm-misc-next

v2:
- DRM_SWITCH_POWER as enum (Daniel Vetter)
- Prefer forward decalration over includes (Laurent Pinchart)
- Updated drm_device to use kerneldoc style (Daniel Vetter)
- Improved commit messages (David Lechner)
- Split up patch when removing drmP.h from drm_gem_cma_helper.h
- rebased on top of drm-misc-next
- dropped patch already applied
- added reviewed-by from Laurent Pinchart (Laurent Pinchart)
- add drm_framebuffer.h patch
- add kernel-doc comments to drm_util.h
- moved EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
- added note to drmP.h not to add new stuff and not to use in new files

Sam Ravnborg (5):
staging/vboxvideo: prepare for drmP.h removal from drm_modeset_helper.h drm/i915: prepare for drmP.h removal from drm_modeset_helper.h drm/rcar-du: prepare for drmP.h removal from drm_modeset_helper.h
drm: prepare for drmP.h removal from drm_modeset_helper.h
drm: remove drmP.h from drm_modeset_helper.h

 drivers/gpu/drm/drm_damage_helper.c       |  1 +
 drivers/gpu/drm/drm_modeset_helper.c      |  2 ++
 drivers/gpu/drm/i915/i915_drv.c           |  4 +++-
 drivers/gpu/drm/i915/intel_atomic.c       |  2 ++
 drivers/gpu/drm/i915/intel_atomic_plane.c |  2 ++
 drivers/gpu/drm/i915/intel_display.c      | 29 ++++++++++++++++-------------
 drivers/gpu/drm/i915/intel_pm.c           |  7 +++++--
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c    |  3 +++
 drivers/gpu/drm/rcar-du/rcar_du_drv.c     |  1 +
 drivers/gpu/drm/rcar-du/rcar_du_kms.c     |  2 ++
 drivers/gpu/drm/rcar-du/rcar_du_plane.c   |  2 ++
 drivers/gpu/drm/rcar-du/rcar_du_vsp.c     |  1 +
 drivers/staging/vboxvideo/vbox_drv.c      |  6 +++++-
 drivers/staging/vboxvideo/vbox_fb.c       | 18 ++++++++++--------
 drivers/staging/vboxvideo/vbox_mode.c     |  5 ++++-
 include/drm/drm_modeset_helper.h          |  6 +++++-
 16 files changed, 64 insertions(+), 27 deletions(-)

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx