Add "git config --move-to"
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | config.c: avoid git_path() in do_git_config_sequence()config.c | +8 | 1 reply | |
| 2/6 | worktree.c: add get_worktree_config()builtin/ worktree.c worktree.h | +25 | 1 reply | |
| 3/6 | config.c: add repo_config_set_worktree_gently()config.c config.h | +43 | 2 replies | |
| 4/6 | config: use OPT_FILENAME()builtin/ | +1 | 1 reply | |
| 5/6 | config: factor out set_config_source_file()builtin/ | +59 | 0 replies | |
| 6/6 | config: add --move-toDocumentation/ Documentation/ builtin/ +1 more | +196 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/6] Add "git config --move-to"
This is a continuation of nd/per-worktree-config, fixing is small things from that series and prepares to make submodules work in multiple worktrees.
The first thing is adding API for updating per-worktree config in 03/06. When submodule code wants to write to a per-worktree config, calling this function takes care of both single and multi worktree setups, similar to "git config --worktree <name> <value>"
The second thing is "git config --move-to" and friends. This helps the config transition right after enabling extensions.worktreeConfig, when the user has to make sure per-worktree config stays in per-worktree file.
Manual moving config from one file to another is possible with a couple keys like core.worktree, but once you have to move multiple groups (i.e. "submodule.*.*" keys) then it becomes a lot less fun and more pain. This simplifies that work (and also migration documentation)
Note that I added --move-glob-to because I think glob fits much better than regex for matching keys because of the dots in config keys. I added --move-regex-to anyway because we have --get-regexp. Maybe I should add --get-glob too (but probably not now).
There is also a NEEDSWORK in 03/06. But I hope it could be addressed after this series is merged (so that I could continue pushing submodule changes out)
Nguyễn Thái Ngọc Duy (6):
config.c: avoid git_path() in do_git_config_sequence() worktree.c: add get_worktree_config() config.c: add repo_config_set_worktree_gently()
config: use OPT_FILENAME()
config: factor out set_config_source_file()
config: add --move-to
Documentation/git-config.txt | 12 ++ Documentation/git-worktree.txt | 16 ++- builtin/config.c | 244 ++++++++++++++++++++++++--------- config.c | 55 +++++++- config.h | 3 + t/t1300-config.sh | 54 ++++++++ worktree.c | 16 +++ worktree.h | 7 + 8 files changed, 330 insertions(+), 77 deletions(-)
Signature · 1 line
2.20.0.482.g66447595a7