Skip to content

usbnet: smsc95xx: Convert to phydev

Marek Vasut linux-usb netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19usbnet: smsc95xx: Fix memory leak in smsc95xx_binddrivers/net/usb/smsc95xx.c+4 -10 replies
2/19usbnet: smsc95xx: Stop propagation of in_pmdrivers/net/usb/smsc95xx.c+33 -302 replies
3/19usbnet: smsc95xx: Remove smsc95xx_{read,write}_reg_nopm()drivers/net/usb/smsc95xx.c+33 -450 replies
4/19usbnet: smsc95xx: Remove __smsc95xx_{read,write}_reg()drivers/net/usb/smsc95xx.c+10 -220 replies
5/19usbnet: smsc95xx: Remove smsc95xx_{read,write}_nopm()drivers/net/usb/smsc95xx.c+9 -210 replies
6/19usbnet: smsc95xx: Remove __smsc95xx_mdio_{read,write}()drivers/net/usb/smsc95xx.c+3 -140 replies
7/19usbnet: smsc95xx: Split the reset functiondrivers/net/usb/smsc95xx.c+27 -91 reply
8/19usbnet: smsc95xx: Register MII busdrivers/net/usb/smsc95xx.c+65 -120 replies
9/19usbnet: smsc95xx: Connect to phydevdrivers/net/usb/smsc95xx.c+27 -22 replies
10/19usbnet: smsc95xx: Replace smsc95xx_mdio_read() with phy_read()drivers/net/usb/smsc95xx.c+20 -176 replies
11/19usbnet: smsc95xx: Replace smsc95xx_mdio_write() with phy_write()drivers/net/usb/smsc95xx.c+10 -120 replies
12/19usbnet: smsc95xx: Replace ad-hoc PHY functions with generic onesdrivers/net/usb/smsc95xx.c+7 -162 replies
13/19usbnet: smsc95xx: Replace smsc95xx_link_ok_nopm()drivers/net/usb/smsc95xx.c+3 -80 replies
14/19usbnet: smsc95xx: Replace mii_nway_restart()drivers/net/usb/smsc95xx.c+4 -10 replies
15/19usbnet: smsc95xx: Replace mii_ethtool_gset()drivers/net/usb/smsc95xx.c+6 -50 replies
16/19usbnet: smsc95xx: Replace mii_check_media()drivers/net/usb/smsc95xx.c+1 -20 replies
17/19usbnet: smsc95xx: Replace generic_mii_ioctl()drivers/net/usb/smsc95xx.c+2 -10 replies
18/19usbnet: smsc95xx: Remove all of the carrier checking codedrivers/net/usb/smsc95xx.c+5 -480 replies
19/19usbnet: smsc95xx: Use phy bit operationsdrivers/net/usb/smsc95xx.c+22 -450 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] usbnet: smsc95xx: Convert to phydev

This series first cleans up the in_pm variable and _nopm() functions, in preparations for conversion to phy_device instead of ad-hoc PHY configuration.

This is followed by a registration of an MDIO bus, attaching a PHY device to it and conversion and cleanup of assorted functions to use the new PHY device functions.

This patchset also allows using other PHYs but the internal one, since the PHY code scans for the first available PHY, however the code was only tested with the internal PHY on a RasPi B+ thus far, as that is the most common use for this device it seems.

Cc David S. Miller <[email protected]>
Cc Nisar Sayed <[email protected]>
Cc Woojung Huh <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Florian Fainelli <[email protected]>

To: [email protected]

Marek Vasut (19):
usbnet: smsc95xx: Fix memory leak in smsc95xx_bind
usbnet: smsc95xx: Stop propagation of in_pm
usbnet: smsc95xx: Remove smsc95xx_{read,write}_reg_nopm()
usbnet: smsc95xx: Remove __smsc95xx_{read,write}_reg()
usbnet: smsc95xx: Remove smsc95xx_{read,write}_nopm()
usbnet: smsc95xx: Remove __smsc95xx_mdio_{read,write}()
usbnet: smsc95xx: Split the reset function
usbnet: smsc95xx: Register MII bus
usbnet: smsc95xx: Connect to phydev
usbnet: smsc95xx: Replace smsc95xx_mdio_read() with phy_read()
usbnet: smsc95xx: Replace smsc95xx_mdio_write() with phy_write()
usbnet: smsc95xx: Replace ad-hoc PHY functions with generic ones
usbnet: smsc95xx: Replace smsc95xx_link_ok_nopm()
usbnet: smsc95xx: Replace mii_nway_restart()
usbnet: smsc95xx: Replace mii_ethtool_gset()
usbnet: smsc95xx: Replace mii_check_media()
usbnet: smsc95xx: Replace generic_mii_ioctl()
usbnet: smsc95xx: Remove all of the carrier checking code
usbnet: smsc95xx: Use phy bit operations

 drivers/net/usb/smsc95xx.c | 478 ++++++++++++++++++-------------------
 1 file changed, 229 insertions(+), 249 deletions(-)
Signature · 1 line
2.19.2