xfrm: policy: fix various bugs
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | selftests: xfrm: add block rules with adjacent/overlapping subnetstools/ | +91 | 0 replies | |
| 2/7 | xfrm: policy: use hlist rcu variants on inexact insert, part 2net/ | +2 | 0 replies | |
| 3/7 | xfrm: policy: increment xfrm_hash_generation on hash rebuildnet/ | +2 | 0 replies | |
| 4/7 | xfrm: policy: delete inexact policies from inexact list on hash rebuildnet/ | +10 | 2 replies | |
| 5/7 | xfrm: policy: fix reinsertion on node mergenet/ | +8 | 2 replies | |
| 6/7 | selftests: xfrm: alter htresh to trigger move of policies to hash tabletools/ | +40 | 0 replies | |
| 7/7 | xfrm: policy: fix infinite loop when merging src-nodesnet/ tools/ | +9 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH ipsec 0/7] xfrm: policy: fix various bugs
This series addresses various bugs, mostly fallout from the recent rcu tree work. One is a fix for an older bug coming from the initial rcu conversion.
There were several xfrm policy related syzbot bugs recently, but so far only one of them has a reproducer (addressed by patch #4).
As I provided ample rope for syzbot to hang itself with, there is some chance that this and the other fixes also resolve the KASAN and UAF syzbot xfrm reports reported in the last couple of days.
My plan is to wait until these patches are applied, and then tell syzbot for all the open reports that the last patch 'fixes this'.
AFAIU that will make syzbot report the problem again in case it can still trigger similar splats with these fixes in place.
Florian Westphal (7):
selftests: xfrm: add block rules with adjacent/overlapping subnets
xfrm: policy: use hlist rcu variants on inexact insert, part 2
xfrm: policy: increment xfrm_hash_generation on hash rebuild
xfrm: policy: delete inexact policies from inexact list on hash rebuild
xfrm: policy: fix reinsertion on node merge
selftests: xfrm: alter htresh to trigger move of policies to hash table
xfrm: policy: fix infinite loop when merging src-nodes
net/xfrm/xfrm_policy.c | 58 +++++----- tools/testing/selftests/net/xfrm_policy.sh | 153 ++++++++++++++++++++++++----- 2 files changed, 160 insertions(+), 51 deletions(-)