Skip to content

hw: Remove "hw/devices.h"

Philippe Mathieu-Daudé qemu-arm qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 2 repliesIn review
  2. v211 patches 9 repliesSuperseded
  3. v116 patches 22 repliesSuperseded

Changes in v3 from the cover letter

- rebased
- added 2 patches suggested by Markus
- addressed Markus review comments
- added Markus's R-b

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded stringhw/arm/aspeed.c+9 -40 replies
2/12hw/arm/nseries: Use TYPE_TMP105 instead of hardcoded stringhw/arm/nseries.c+2 -10 replies
3/12hw/display/tc6393xb: Remove unused functionshw/display/tc6393xb.c include/hw/devices.h+0 -190 replies
4/12hw/devices: Move TC6393XB declarations into a new headerMAINTAINERS hw/arm/tosa.c hw/display/tc6393xb.c +2 more+27 -80 replies
5/12hw/devices: Move Blizzard declarations into a new headerMAINTAINERS hw/arm/nseries.c hw/display/blizzard.c +2 more+26 -80 replies
6/12hw/devices: Move CBus declarations into a new headerMAINTAINERS hw/arm/nseries.c hw/misc/cbus.c +2 more+35 -150 replies
7/12hw/devices: Move Gamepad declarations into a new headerMAINTAINERS hw/arm/stellaris.c hw/input/stellaris_input.c +2 more+22 -50 replies
8/12hw/devices: Move TI touchscreen declarations into a new headerMAINTAINERS hw/arm/nseries.c hw/arm/palm.c +6 more+44 -260 replies
9/12hw/devices: Move LAN9118 declarations into a new headerhw/arm/kzm.c hw/arm/mps2.c hw/arm/realview.c +4 more+24 -70 replies
10/12hw/net/ne2000-isa: Add guards to the headerinclude/hw/net/ne2000-isa.h+6 -00 replies
11/12hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded stringhw/arm/exynos4_boards.c hw/arm/mps2-tz.c hw/net/lan9118.c +1 more+6 -30 replies
12/12hw/devices: Move SMSC 91C111 declaration into a new headerhw/arm/gumstix.c hw/arm/integratorcp.c hw/arm/mainstone.c +5 more+25 -170 replies

Reviews trailers per patch

10 of 12 patches have a Reviewed-by or Acked-by.

PatchThomas HuthCédric Le GoaterMarkus Armbruster
1/12R-b R-b R-b
2/12
3/12
4/12R-b
5/12R-b R-b
6/12R-b R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [Qemu-arm] [PATCH v3 00/12] hw: Remove "hw/devices.h"

Hi,

As his first comment describes itself, the "hw/devices.h" contains declarations for "Devices that have nowhere better to go." This series remove it, creating new headers for devices covered there. MAINTAINERS is updated.
I also included 2 cleanups while working on this, in "qemu/typedefs.h" and "hw/net/ne2000-isa.h" header guard.

v3:
- rebased
- added 2 patches suggested by Markus
- addressed Markus review comments
- added Markus's R-b

v2: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00925.html
- added R-b, T-b tags
- addressed many review comments from Thomas

v1: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00611.html

Phil.

$ git backport-diff -u remove_hw_devices-v2
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/12:[----] [-C] 'hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string' 002/12:[down] 'hw/arm/nseries: Use TYPE_TMP105 instead of hardcoded string' 003/12:[down] 'hw/display/tc6393xb: Remove unused functions'
004/12:[0006] [FC] 'hw/devices: Move TC6393XB declarations into a new header' 005/12:[----] [-C] 'hw/devices: Move Blizzard declarations into a new header' 006/12:[----] [-C] 'hw/devices: Move CBus declarations into a new header' 007/12:[0002] [FC] 'hw/devices: Move Gamepad declarations into a new header' 008/12:[0002] [FC] 'hw/devices: Move TI touchscreen declarations into a new header' 009/12:[----] [--] 'hw/devices: Move LAN9118 declarations into a new header' 010/12:[----] [--] 'hw/net/ne2000-isa: Add guards to the header'
011/12:[----] [--] 'hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string' 012/12:[----] [--] 'hw/devices: Move SMSC 91C111 declaration into a new header'

Philippe Mathieu-Daudé (12):
hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded
string
hw/arm/nseries: Use TYPE_TMP105 instead of hardcoded string hw/display/tc6393xb: Remove unused functions
hw/devices: Move TC6393XB declarations into a new header hw/devices: Move Blizzard declarations into a new header hw/devices: Move CBus declarations into a new header hw/devices: Move Gamepad declarations into a new header hw/devices: Move TI touchscreen declarations into a new header hw/devices: Move LAN9118 declarations into a new header hw/net/ne2000-isa: Add guards to the header hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded
string
hw/devices: Move SMSC 91C111 declaration into a new header

 MAINTAINERS                   |  7 ++++
 hw/arm/aspeed.c               | 13 +++++---
 hw/arm/exynos4_boards.c       |  3 +-
 hw/arm/gumstix.c              |  2 +-
 hw/arm/integratorcp.c         |  2 +-
 hw/arm/kzm.c                  |  2 +-
 hw/arm/mainstone.c            |  2 +-
 hw/arm/mps2-tz.c              |  3 +-
 hw/arm/mps2.c                 |  2 +-
 hw/arm/nseries.c              |  7 ++--
 hw/arm/palm.c                 |  2 +-
 hw/arm/realview.c             |  3 +-
 hw/arm/stellaris.c            |  2 +-
 hw/arm/tosa.c                 |  2 +-
 hw/arm/versatilepb.c          |  2 +-
 hw/arm/vexpress.c             |  2 +-
 hw/display/blizzard.c         |  2 +-
 hw/display/tc6393xb.c         | 18 +---------
 hw/input/stellaris_input.c    |  2 +-
 hw/input/tsc2005.c            |  2 +-
 hw/input/tsc210x.c            |  4 +--
 hw/misc/cbus.c                |  2 +-
 hw/net/lan9118.c              |  3 +-
 hw/net/smc91c111.c            |  2 +-
 include/hw/arm/omap.h         |  6 +---
 include/hw/devices.h          | 62 -----------------------------------
 include/hw/display/blizzard.h | 22 +++++++++++++
 include/hw/display/tc6393xb.h | 24 ++++++++++++++
 include/hw/input/gamepad.h    | 19 +++++++++++
 include/hw/input/tsc2xxx.h    | 36 ++++++++++++++++++++
 include/hw/misc/cbus.h        | 32 ++++++++++++++++++
 include/hw/net/lan9118.h      | 21 ++++++++++++
 include/hw/net/ne2000-isa.h   |  6 ++++
 include/hw/net/smc91c111.h    | 19 +++++++++++
 include/qemu/typedefs.h       |  1 -
 35 files changed, 226 insertions(+), 113 deletions(-)
 delete mode 100644 include/hw/devices.h
 create mode 100644 include/hw/display/blizzard.h
 create mode 100644 include/hw/display/tc6393xb.h
 create mode 100644 include/hw/input/gamepad.h
 create mode 100644 include/hw/input/tsc2xxx.h
 create mode 100644 include/hw/misc/cbus.h
 create mode 100644 include/hw/net/lan9118.h
 create mode 100644 include/hw/net/smc91c111.h
Signature · 1 line
2.20.1