Skip to content

arm: Stub out NRF51 TWI magnetometer/accelerometer detection

Stefan Hajnoczi qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 7 repliesIn review
  2. v11 patch 3 repliesSuperseded

Changes in v2 from the cover letter

* Move stub code into a separate device [Peter]
* Instantiate stub from microbit board instead of nRF51 SoC since this is microbit-specific. Other boards using the nRF51 wouldn't necessarily want to see these TWI/I2C devices.
* Add test case

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2arm: Stub out NRF51 TWI magnetometer/accelerometer detectionhw/arm/microbit.c hw/i2c/Makefile.objs hw/i2c/microbit_i2c.c +3 more+188 -02 replies
2/2tests/microbit-test: add TWI stub device testtests/microbit-test.c+44 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-arm] [PATCH v2 0/2] arm: Stub out NRF51 TWI magnetometer/accelerometer detection

v2:
* Move stub code into a separate device [Peter]
* Instantiate stub from microbit board instead of nRF51 SoC since this is microbit-specific. Other boards using the nRF51 wouldn't necessarily want to see these TWI/I2C devices.
* Add test case

This series stubs out the microbit's TWI/I2C devices so the microbit-dal firmware boots successfully. The accelerometer and magnetometer are probed at startup. If they are not found the firmware panics.

Stefan Hajnoczi (1):
tests/microbit-test: add TWI stub device test

Steffen Görtz (1):
arm: Stub out NRF51 TWI magnetometer/accelerometer detection

 hw/i2c/Makefile.objs          |   1 +
 include/hw/arm/nrf51.h        |   2 +
 include/hw/arm/nrf51_soc.h    |   1 +
 include/hw/i2c/microbit_i2c.h |  42 +++++++++++
 hw/arm/microbit.c             |  15 ++++
 hw/i2c/microbit_i2c.c         | 127 ++++++++++++++++++++++++++++++++++
 tests/microbit-test.c         |  44 ++++++++++++
 7 files changed, 232 insertions(+)
 create mode 100644 include/hw/i2c/microbit_i2c.h
 create mode 100644 hw/i2c/microbit_i2c.c
Signature · 1 line
2.20.1