Skip to content

net: lora: sx130x: Fixes for enabling regcache

Andreas Färber lkml netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11net: lora: sx125x: Abort on wrong versiondrivers/net/lora/sx125x.c+5 -10 replies
2/11net: lora: sx130x: Fix error codesdrivers/net/lora/sx130x.c+5 -50 replies
3/11net: lora: sx130x: Revert drop of sx1301_soft_reset()drivers/net/lora/sx130x.c+6 -10 replies
4/11net: lora: sx130x: Fix soft resetdrivers/net/lora/sx130x.c+13 -10 replies
5/11net: lora: sx130x: Fix regmap field togglesdrivers/net/lora/sx130x.c+9 -30 replies
6/11net: lora: sx130x: Force regmap field write before sleepdrivers/net/lora/sx130x.c+1 -10 replies
7/11net: lora: sx130x: Force regmap field writes before function boundariesdrivers/net/lora/sx130x.c+5 -50 replies
8/11net: lora: sx130x: Force regmap field write before reading statusdrivers/net/lora/sx130x.c+1 -10 replies
9/11net: lora: sx130x: Mark AGCSTS register as volatiledrivers/net/lora/sx130x.c+4 -20 replies
10/11net: lora: sx130x: Mark MCU_CTRL register as volatiledrivers/net/lora/sx130x.c+2 -00 replies
11/11net: lora: sx130x: Enable regmap cachingdrivers/net/lora/sx130x.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH lora-next 00/11] net: lora: sx130x: Fixes for enabling regcache

Hello,

This series fixes a number of issues that stood in the way of enabling the regmap cache for SX130x. It goes on to enable REGCACHE_RBTREE.

1) Soft reset needs special treatment.
2) More registers need to be treated as volatile.
3) Some register field writes need to be forced.

This complements Ben Whitten's regmap conversion patches [1] I already squashed, mainly [2]. I intend to squash these into my driver commit as well.

In my testing it has not regressed with spi-gpio or cdc-acm, nor with spi-sun6i; given that we seem no closer to a solution for the clk lock-up, we may need to revert that commit from [1] again.

Have a lot of fun!

Cheers,
Andreas

[1] https://patchwork.ozlabs.org/cover/983168/
[2] https://patchwork.ozlabs.org/patch/983170/

Andreas Färber (11):
net: lora: sx125x: Abort on wrong version
net: lora: sx130x: Fix error codes
net: lora: sx130x: Revert drop of sx1301_soft_reset()
net: lora: sx130x: Fix soft reset
net: lora: sx130x: Fix regmap field toggles
net: lora: sx130x: Force regmap field write before sleep
net: lora: sx130x: Force regmap field writes before function
boundaries
net: lora: sx130x: Force regmap field write before reading status
net: lora: sx130x: Mark AGCSTS register as volatile
net: lora: sx130x: Mark MCU_CTRL register as volatile
net: lora: sx130x: Enable regmap caching

 drivers/net/lora/sx125x.c |  6 ++++-
 drivers/net/lora/sx130x.c | 65 +++++++++++++++++++++++++++++++++--------------
 2 files changed, 51 insertions(+), 20 deletions(-)
Signature · 1 line
2.16.4