Skip to content

PCI: endpoint: Cleanup EPC features

Kishon Vijay Abraham I linux-arm-kernel linux-omap linux-pci linux-rockchip lkml 2 versions – Applied

Status from this message: Applied to pci/endpoint for v5.1, thanks !

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 9 repliesApplied
  2. v115 patches 10 repliesSuperseded

Changes in v2 from the cover letter

*) Fixed helper function to return '0' (or BAR_0) for any incorrect
values in reserved BAR.
*) Do not set_bar or alloc space for BARs if the BARs are reserved *) Fix incorrect check of epc_features in pci_epf_test_bind

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/15PCI: endpoint: Add new pci_epc_ops to get EPC featuresdrivers/pci/endpoint/pci-epc-core.c include/linux/pci-epc.h+52 -00 replies
2/15PCI: dwc: Add ->get_features() callback function in dw_pcie_ep_opsdrivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/controller/dwc/pcie-designware.h+13 -00 replies
3/15PCI: designware-plat: Populate ->get_features() dw_pcie_ep_opsdrivers/pci/controller/dwc/pcie-designware-plat.c+13 -00 replies
4/15PCI: pci-dra7xx: Populate ->get_features() dw_pcie_ep_opsdrivers/pci/controller/dwc/pci-dra7xx.c+13 -00 replies
5/15PCI: rockchip: Populate ->get_features() dw_pcie_ep_opsdrivers/pci/controller/pcie-rockchip-ep.c+13 -00 replies
6/15PCI: cadence: Populate ->get_features() cdns_pcie_epc_opsdrivers/pci/controller/pcie-cadence-ep.c+13 -00 replies
7/15PCI: endpoint: Add helper to get first unreserved BARdrivers/pci/endpoint/pci-epc-core.c include/linux/pci-epc.h+25 -00 replies
8/15PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flagsdrivers/pci/endpoint/pci-epf-core.c+3 -15 replies
9/15PCI: pci-epf-test: Remove setting epf_bar flags in function driverdrivers/pci/endpoint/functions/pci-epf-test.c+0 -40 replies
10/15PCI: pci-epf-test: Do not allocate next BARs memory if current BAR is 64Bitdrivers/pci/endpoint/functions/pci-epf-test.c+4 -00 replies
11/15PCI: pci-epf-test: Use pci_epc_get_features to get EPC featuresdrivers/pci/endpoint/functions/pci-epf-test.c+54 -330 replies
12/15PCI: cadence: Remove pci_epf_linkup from Cadence EP driverdrivers/pci/controller/pcie-cadence-ep.c+0 -120 replies
13/15PCI: rockchip: Remove pci_epf_linkup from Rockchip EP driverdrivers/pci/controller/pcie-rockchip-ep.c+0 -30 replies
14/15PCI: designware-plat: Remove setting epc->features in Designware plat EP driverdrivers/pci/controller/dwc/pcie-designware-plat.c+0 -40 replies
15/15PCI: endpoint: Remove features member in struct pci_epcinclude/linux/pci-epc.h+0 -90 replies

Reviews trailers per patch

None of the 15 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchShawn LinGustavo Pimentel
SeriesA-b T-b
1/15
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/15] PCI: endpoint: Cleanup EPC features

Hi Lorenzo,

The Endpoint controller driver uses features member in 'struct pci_epc' to advertise the list of supported features to the endpoint function driver.

There are a few shortcomings with this approach.
*) Certain endpoint controllers support fixed size BAR (e.g. TI's
AM654 uses Designware configuration with fixed size BAR). The size of each BARs cannot be passed to the endpoint function driver.
*) Too many macros for handling EPC features.
(EPC_FEATURE_NO_LINKUP_NOTIFIER, EPC_FEATURE_BAR_MASK,
EPC_FEATURE_MSIX_AVAILABLE, EPC_FEATURE_SET_BAR, EPC_FEATURE_GET_BAR)
*) Endpoint controllers are directly modifying struct pci_epc
members. (I have plans to move struct pci_epc to drivers/pci/endpoint so that pci_epc members are referenced only by endpoint core).

To overcome the above shortcomings, introduced pci_epc_get_features() API, pci_epc_features structure and a ->get_features() callback.

Also added a patch to set BAR flags in pci_epf_alloc_space and remove it from pci-epf-test function driver.

Changes from v1:
*) Fixed helper function to return '0' (or BAR_0) for any incorrect
values in reserved BAR.
*) Do not set_bar or alloc space for BARs if the BARs are reserved *) Fix incorrect check of epc_features in pci_epf_test_bind

Tested on TI's DRA7xx platform and AM654 platform. Support for PCIe in AM654 platform will be posted shortly.

Kishon Vijay Abraham I (15):
PCI: endpoint: Add new pci_epc_ops to get EPC features
PCI: dwc: Add ->get_features() callback function in dw_pcie_ep_ops
PCI: designware-plat: Populate ->get_features() dw_pcie_ep_ops
PCI: pci-dra7xx: Populate ->get_features() dw_pcie_ep_ops
PCI: rockchip: Populate ->get_features() dw_pcie_ep_ops
PCI: cadence: Populate ->get_features() cdns_pcie_epc_ops
PCI: endpoint: Add helper to get first unreserved BAR
PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flags
PCI: pci-epf-test: Remove setting epf_bar flags in function driver
PCI: pci-epf-test: Do not allocate next BARs memory if current BAR is

    64Bit

PCI: pci-epf-test: Use pci_epc_get_features to get EPC features
PCI: cadence: Remove pci_epf_linkup from Cadence EP driver
PCI: rockchip: Remove pci_epf_linkup from Rockchip EP driver
PCI: designware-plat: Remove setting epc->features in Designware plat
EP driver
PCI: endpoint: Remove features member in struct pci_epc

 drivers/pci/controller/dwc/pci-dra7xx.c       | 13 +++
 .../pci/controller/dwc/pcie-designware-ep.c   | 12 +++
 .../pci/controller/dwc/pcie-designware-plat.c | 17 +++-
 drivers/pci/controller/dwc/pcie-designware.h  |  1 +
 drivers/pci/controller/pcie-cadence-ep.c      | 25 ++---
 drivers/pci/controller/pcie-rockchip-ep.c     | 16 +++-
 drivers/pci/endpoint/functions/pci-epf-test.c | 93 ++++++++++++-------
 drivers/pci/endpoint/pci-epc-core.c           | 53 +++++++++++
 drivers/pci/endpoint/pci-epf-core.c           |  4 +-
 include/linux/pci-epc.h                       | 31 +++++--
 10 files changed, 201 insertions(+), 64 deletions(-)
Signature · 1 line
2.17.1