Skip to content

PCI: Fix runtime PME generation from D3hot

Mika Westerberg linux-pci lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesIn review
  2. v12 patches 5 repliesSuperseded

Changes from the previous version from the cover letter

* Add tags from Heiner and Rafael
* Update changelog to mention relevent PCIe spec sections
* Add comment to pcie_disable_interrupt() explaining why and what is masked

[1] https://www.spinics.net/lists/linux-pci/msg79051.html

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Revert "PCI/PME: Implement runtime PM callbacks"drivers/pci/pcie/pme.c+0 -270 replies
2/2PCI: pciehp: Disable Data Link Layer State Changed event on suspenddrivers/pci/hotplug/pciehp_hpc.c+15 -22 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRafael J. WysockiHeiner Kallweit
1/2A-b T-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] PCI: Fix runtime PME generation from D3hot

Hi all,

Heiner reported [1] that runtime PME generation of his network card does not work after commit 0e157e528604 ("PCI/PME: Implement runtime PM callbacks") that landed in v4.20. Reverting the commit helps but it has another drawback, which I originally tried to solve with the commit, that the PCIe hierarchy wakes up immediately after being put into D3cold.

This series of two patches tries to fix both issues so that PME wakes up from D3hot and that the hierarchy does not wake up immediately from D3cold.

The previous version of the series can be found here:

https://www.mail-archive.com/[email protected]/msg1892241.html

Changes from the previous version:

* Add tags from Heiner and Rafael
* Update changelog to mention relevent PCIe spec sections
* Add comment to pcie_disable_interrupt() explaining why and what is masked

[1] https://www.spinics.net/lists/linux-pci/msg79051.html

Mika Westerberg (2):
Revert "PCI/PME: Implement runtime PM callbacks"
PCI: pciehp: Disable Data Link Layer State Changed event on suspend

 drivers/pci/hotplug/pciehp_hpc.c | 17 +++++++++++++++--
 drivers/pci/pcie/pme.c           | 27 ---------------------------
 2 files changed, 15 insertions(+), 29 deletions(-)
Signature · 1 line
2.20.1