Skip to content

machine: Make compat_props arrays shorter and more readable

Eduardo Habkost qemu-devel xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macrohw/ppc/spapr.c include/hw/pci-host/spapr.h+1 -23 replies
2/3machine: Eliminate unnecessary stringify() usagehw/core/machine.c hw/i386/pc.c hw/i386/pc_piix.c +1 more+67 -674 replies
3/3machine: Use shorter format for GlobalProperty arrayshw/core/machine.c hw/i386/pc.c hw/i386/pc_piix.c +4 more+265 -11687 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMarc-André LureauDavid GibsonCornelia HuckPhilippe Mathieu-Daudé
1/3R-b A-b R-b
2/3R-b R-b R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] machine: Make compat_props arrays shorter and more readable

Current declarations of compat_props arrays are very verbose, with each entry taking 4 lines of code. By omitting the field designators, we can make each array entry fit a single line of code and be more readable.

Eduardo Habkost (3):
spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macro
machine: Eliminate unnecessary stringify() usage
machine: Use shorter format for GlobalProperty arrays

 include/hw/i386/pc.h        |  18 +-
 include/hw/pci-host/spapr.h |   1 -
 hw/core/machine.c           | 338 ++++-------------
 hw/i386/pc.c                | 720 +++++++-----------------------------
 hw/i386/pc_piix.c           | 192 ++--------
 hw/ppc/spapr.c              |  72 +---
 hw/s390x/s390-virtio-ccw.c  |  75 +---
 hw/xen/xen-common.c         |  18 +-
 8 files changed, 265 insertions(+), 1169 deletions(-)
Signature · 7 lines
2.18.0.rc1.1.g3f1ff2140


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel