Skip to content

multipath-tools: Coverity patches

Martin Wilck dm-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12kpartx(coverity): fix resource leak warningkpartx/dasd.c+2 -30 replies
2/12libmultipath(coverity): cleanup dup usage in execute_program()libmultipath/callout.c+7 -60 replies
3/12kpartx(coverity): fix apparent out-of-bounds accesskpartx/dasd.c+1 -10 replies
4/12libmultipath(coverity): make sure readlink result is 0-terminatedlibmultipath/util.c+1 -00 replies
5/12libmultipath(coverity): fix apparent overflowlibmultipath/discovery.c+1 -10 replies
6/12libmpathcmd(coverity): limit reply lengthlibmpathcmd/mpath_cmd.c libmpathcmd/mpath_cmd.h multipathd/cli.c +2 more+19 -00 replies
7/12libmultipath(coverity): fix int overflow in sysfs_set_scsi_tmolibmultipath/discovery.c+1 -10 replies
8/12libmultipath(coverity): fix "enum misuse" for find_multipathslibmultipath/dict.c+1 -13 replies
9/12multipathd(coverity): check retval clock_gettime()multipathd/main.c+5 -40 replies
10/12libmpathpersist(coverity): range checking for PRIN lengthlibmpathpersist/mpath_pr_ioctl.c+7 -30 replies
11/12libmultipath/foreign(coverity): retval check in snprint_nvme_pathlibmultipath/foreign/nvme.c+4 -20 replies
12/12libmultipath(coverity): fix possible NULL dereferencelibmultipath/configure.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] multipath-tools: Coverity patches

Hi Christophe,

here are a few simple fixes motivated by a recent coverity scan of the latest upstream. Most are false positives, but it can't hurt to fix them anyway, be it only to get a quicker overview on future scans.

Unfortunately synopsys messed up the scan.coverity.com website before I could finish this work.

There are two bigger issues with coverity that this set doesn't address:

1) apparently coverity doesn't understand our frequently

    used paradigm (simplified):

    pthread_cleanup_push(pthread_mutex_unlock, &mutex);
    pthread_mutex_lock(&mutex);
    do_some_work();
    pthread_cleanup_pop(1);

2) coverity warns that we sleep in multiple places holding the vecs lock. That will be a bit harder to fix.

Martin

Martin Wilck (12):
kpartx(coverity): fix resource leak warning libmultipath(coverity): cleanup dup usage in execute_program() kpartx(coverity): fix apparent out-of-bounds access libmultipath(coverity): make sure readlink result is 0-terminated libmultipath(coverity): fix apparent overflow libmpathcmd(coverity): limit reply length libmultipath(coverity): fix int overflow in sysfs_set_scsi_tmo libmultipath(coverity): fix "enum misuse" for find_multipaths multipathd(coverity): check retval clock_gettime() libmpathpersist(coverity): range checking for PRIN length libmultipath/foreign(coverity): retval check in snprint_nvme_path libmultipath(coverity): fix possible NULL dereference

 kpartx/dasd.c                    |  7 +++----
 libmpathcmd/mpath_cmd.c          |  4 ++++
 libmpathcmd/mpath_cmd.h          |  6 ++++++
 libmpathpersist/mpath_pr_ioctl.c | 10 +++++++---
 libmultipath/callout.c           | 13 +++++++------
 libmultipath/configure.c         |  2 +-
 libmultipath/dict.c              |  2 +-
 libmultipath/discovery.c         |  4 ++--
 libmultipath/foreign/nvme.c      |  6 ++++--
 libmultipath/util.c              |  1 +
 multipathd/cli.c                 |  2 ++
 multipathd/cli.h                 |  6 ++++++
 multipathd/cli_handlers.c        |  1 +
 multipathd/main.c                |  9 +++++----
 14 files changed, 50 insertions(+), 23 deletions(-)
Signature · 1 line
2.19.2