Skip to content

Promote x-nbd-server-add-bitmap to stable

Eric Blake qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 6 repliesIn review
  2. v26 patches 13 repliesSuperseded
  3. v15 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- split old patch 1 into 3 parts
- add even more tests of expected error messages
- rebase on top of 'exp' rename
- improve commit messages
- add some R-b where it made sense

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8nbd: Add some error case testing to iotests 223tests/qemu-iotests/223 tests/qemu-iotests/223.out+24 -22 replies
2/8nbd: Forbid nbd-server-stop when server is not runningblockdev-nbd.c tests/qemu-iotests/223 tests/qemu-iotests/223.out+7 -21 reply
3/8nbd: Only require disabled bitmap for read-only exportsnbd/server.c tests/qemu-iotests/223 tests/qemu-iotests/223.out+14 -62 replies
4/8nbd: Merge nbd_export_set_name into nbd_export_newblockdev-nbd.c include/block/nbd.h nbd/server.c +1 more+29 -390 replies
5/8nbd: Allow bitmap export during QMP nbd-server-addblockdev-nbd.c hmp.c qapi/block.json +2 more+29 -190 replies
6/8nbd: Remove x-nbd-server-add-bitmapblockdev-nbd.c qapi/block.json+0 -460 replies
7/8nbd: Merge nbd_export_bitmap into nbd_export_newblockdev-nbd.c include/block/nbd.h nbd/server.c +1 more+47 -650 replies
8/8qemu-nbd: Add --bitmap=NAME optionqemu-nbd.c qemu-nbd.texi tests/qemu-iotests/223 +1 more+40 -40 replies

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-Ogievskiy
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/8] Promote x-nbd-server-add-bitmap to stable

Or rather, move its functionality into nbd-server-add. And as a side effect, teach qemu-nbd how to export a persistent bitmap without having to go through a qemu process and several QMP commands.

Based-on: <[email protected]>
[jsnow: 0/11 bitmaps: remove x- prefix from QMP api]
Based-on: <[email protected]>
[philmd: qemu-nbd: Rename 'exp' variable clashing with math::exp() symbol]

Available at: https://repo.or.cz/qemu/ericb.git nbd-bitmap-add-v3

Since v2:
- split old patch 1 into 3 parts
- add even more tests of expected error messages
- rebase on top of 'exp' rename
- improve commit messages
- add some R-b where it made sense

001/8:[down] 'nbd: Add some error case testing to iotests 223' 002/8:[down] 'nbd: Forbid nbd-server-stop when server is not running' 003/8:[0011] [FC] 'nbd: Only require disabled bitmap for read-only exports' 004/8:[0020] [FC] 'nbd: Merge nbd_export_set_name into nbd_export_new' 005/8:[0008] [FC] 'nbd: Allow bitmap export during QMP nbd-server-add' 006/8:[----] [--] 'nbd: Remove x-nbd-server-add-bitmap' 007/8:[0009] [FC] 'nbd: Merge nbd_export_bitmap into nbd_export_new' 008/8:[0004] [FC] 'qemu-nbd: Add --bitmap=NAME option'

Eric Blake (8):
nbd: Add some error case testing to iotests 223
nbd: Forbid nbd-server-stop when server is not running
nbd: Only require disabled bitmap for read-only exports
nbd: Merge nbd_export_set_name into nbd_export_new
nbd: Allow bitmap export during QMP nbd-server-add
nbd: Remove x-nbd-server-add-bitmap
nbd: Merge nbd_export_bitmap into nbd_export_new
qemu-nbd: Add --bitmap=NAME option

 qemu-nbd.texi              |   4 ++
 qapi/block.json            |  30 ++------
 include/block/nbd.h        |  12 ++--
 blockdev-nbd.c             |  36 +++-------
 hmp.c                      |   5 +-
 nbd/server.c               | 136 +++++++++++++++++--------------------
 qemu-nbd.c                 |  17 +++--
 tests/qemu-iotests/223     |  50 +++++++++++---
 tests/qemu-iotests/223.out |  23 +++++--
 9 files changed, 160 insertions(+), 153 deletions(-)
Signature · 1 line
2.20.1