Skip to content

Missing barriers and VIRTIO_F_ORDER_PLATFORM.

Ilya Maximets dpdk-dev 1 version Applied

Status from this message: Applied to dpdk-next-virtio/master.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest3 patches 11 repliesApplied

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3net/virtio: add missing barrier before reading the flagsdrivers/net/virtio/virtqueue.h+8 -01 reply
2/3net/virtio: update memory ordering comment for vq notifydrivers/net/virtio/virtqueue.h+4 -55 replies
3/3net/virtio: add platform memory ordering feature supportdrivers/net/virtio/virtio_ethdev.c drivers/net/virtio/virtio_ethdev.h drivers/net/virtio/virtio_pci.h +2 more+52 -171 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMichael S. TsirkinMaxime Coquelin
SeriesA-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Missing barriers and VIRTIO_F_ORDER_PLATFORM.

Version 3:
* Added 2 patches with fixes for current virtio driver. Not directly connected with the new feature.

Version 2:
* rebased on current master (packed rings).

RFC --> Version 1:
* Dropped vendor-specific hack to determine if we need real barriers.
* Added VIRTIO_F_ORDER_PLATFORM feature definition and checking.

Note: Patch to change the name of the feature from VIRTIO_F_IO_BARRIER
to VIRTIO_F_ORDER_PLATFORM is not merged yet:
https://www.mail-archive.com/[email protected]/msg04114.html

Ilya Maximets (3):
net/virtio: add missing barrier before reading the flags net/virtio: update memory ordering comment for vq notify net/virtio: add platform memory ordering feature support

 drivers/net/virtio/virtio_ethdev.c |  2 ++
 drivers/net/virtio/virtio_ethdev.h |  3 +-
 drivers/net/virtio/virtio_pci.h    |  7 ++++
 drivers/net/virtio/virtio_rxtx.c   | 16 ++++-----
 drivers/net/virtio/virtqueue.h     | 56 +++++++++++++++++++++++-------
 5 files changed, 63 insertions(+), 21 deletions(-)
Signature · 1 line
2.17.1