sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest3 patches 1 replyIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | sched: Avoid dereferencing skb pointer after child enqueuenet/ net/ net/ +5 more | +23 | 0 replies | |
| 2/3 | sched: Fix detection of empty queues in child qdiscsnet/ net/ net/ | +9 | 0 replies | |
| 3/3 | sch_cake: Correctly update parent qlen when splitting GSO packetsnet/ | +3 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Pete Heist |
|---|---|
| 1/3 | |
| 2/3 | |
| 3/3 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc
This series fixes a couple of issues exposed by running sch_cake as a leaf qdisc in an HFSC tree, which were discovered and reported by Pete Heist. The interaction between CAKE's GSO splitting and the parent qdisc's notion of its own queue length could cause queue stalls. While investigating the report, I also noticed that several qdiscs would dereference the skb pointer after dequeue, which is potentially problematic since the GSO splitting code also frees the original skb.
See the individual patches in the series for details.
Toke Høiland-Jørgensen (3):
sched: Avoid dereferencing skb pointer after child enqueue
sched: Fix detection of empty queues in child qdiscs
sch_cake: Correctly update parent qlen when splitting GSO packets
net/sched/sch_cake.c | 5 +++-- net/sched/sch_cbs.c | 3 ++- net/sched/sch_drr.c | 7 +++++-- net/sched/sch_dsmark.c | 3 ++- net/sched/sch_hfsc.c | 9 +++++---- net/sched/sch_htb.c | 3 ++- net/sched/sch_prio.c | 3 ++- net/sched/sch_qfq.c | 20 ++++++++++++-------- net/sched/sch_tbf.c | 3 ++- 9 files changed, 35 insertions(+), 21 deletions(-)
Signature · 1 line
2.19.1