Skip to content

let kexec_file_load use platform keyring to verify the kernel image

Kairui Song kexec keyrings linux-integrity lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 5 repliesIn review
  2. v42 patches 9 repliesSuperseded
  3. v32 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC2 patches5 repliesSuperseded
v1 RFC2 patches9 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2integrity, KEYS: add a reference to platform keyringcerts/system_keyring.c include/keys/system_keyring.h security/integrity/digsig.c+21 -01 reply
2/2kexec, KEYS: Make use of platform keyring for signature verifyarch/x86/kernel/kexec-bzimage64.c certs/system_keyring.c include/linux/verification.h+23 -42 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchDave Young
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] let kexec_file_load use platform keyring to verify the kernel image

This patch series adds a .platform_trusted_keys in system_keyring as the reference to .platform keyring in integrity subsystem, when platform keyring is being initialized it will be updated, so it will be accessable for verifying PE signed kernel image.

This patch series let kexec_file_load use platform keyring as fall back if it failed to verify the image against secondary keyring, so the actually PE signature verify process will use keys provides by firmware.

After this patch kexec_file_load will be able to verify a signed PE bzImage using keys in platform keyring.

Tested in a VM with locally signed kernel with pesign and imported the cert to EFI's MokList variable.

To test this patch series on latest kernel, you need to ensure this commit is applied as there is an regression bug in sanity_check_segment_list():

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id�3a110319a4a60aadbd02f6defdebe048f7773b

Update from V4:
- Drop ifdef in security/integrity/digsig.c to make code clearer
- Fix a potential issue, set_platform_trusted_keys should not be called when keyring initialization failed

Update from V3:
- Tweak and simplify commit message as suggested by Mimi Zohar

Update from V2:
- Use IS_ENABLED in kexec_file_load to judge if platform_trusted_keys should be used for verifying image as suggested by Mimi Zohar

Update from V1:
- Make platform_trusted_keys static, and update commit message as suggested by Mimi Zohar
- Always check if platform keyring is initialized before use it

Kairui Song (2):
integrity, KEYS: add a reference to platform keyring kexec, KEYS: Make use of platform keyring for signature verify

 arch/x86/kernel/kexec-bzimage64.c | 13 ++++++++++---
 certs/system_keyring.c            | 22 +++++++++++++++++++++-
 include/keys/system_keyring.h     |  9 +++++++++
 include/linux/verification.h      |  1 +
 security/integrity/digsig.c       |  3 +++
 5 files changed, 44 insertions(+), 4 deletions(-)
Signature · 1 line
2.20.1