Skip to content

include: Auto-generate the sizes lookup table

Eric Blake qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest6 patches 10 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6qemu-option: Allow integer defaultsinclude/qemu/option.h util/qemu-option.c+72 -93 replies
2/6block: Take advantage of QemuOpt default integersblock/parallels.c block/qcow2.c block/qed.c +2 more+5 -62 replies
3/6Revert "vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE"block/vdi.c+2 -21 reply
4/6qemu: Prefer '(x * MiB)' over 'S_xiB'block/qcow2.h+5 -50 replies
5/6Revert "include: Add a comment to explain the origin of sizes' lookup table"include/qemu/units.h+0 -180 replies
6/6Revert "include: Add a lookup table of sizes"include/qemu/units.h+0 -550 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKevin Wolf
SeriesA-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/6] include: Auto-generate the sizes lookup table

Patches speak louder than words. This is my counter-proposal to Leonid's thread on how best to respresent the S_*iB macros in units.h, where my proposal is that we don't need them at all. (hence my subject line, even though it is completely unrelated to the series)

True, my diffstat is even bigger, but I think it is more maintainable in the long run (if calling QemuOpts maintainable is even appropriate).

Eric Blake (6):
qemu-option: Allow integer defaults
block: Take advantage of QemuOpt default integers
Revert "vdi: Use a literal number of bytes for DEFAULT_CLUSTER_SIZE"
qemu: Prefer '(x * MiB)' over 'S_xiB'
Revert "include: Add a comment to explain the origin of sizes' lookup
table"
Revert "include: Add a lookup table of sizes"

 block/qcow2.h         | 10 +++---
 include/qemu/option.h | 12 +++++++
 include/qemu/units.h  | 73 -------------------------------------------
 block/parallels.c     |  2 +-
 block/qcow2.c         |  2 +-
 block/qed.c           |  2 +-
 block/vdi.c           |  6 ++--
 block/vhdx.c          |  3 +-
 util/qemu-option.c    | 69 ++++++++++++++++++++++++++++++++++------
 9 files changed, 84 insertions(+), 95 deletions(-)
Signature · 1 line
2.20.1