Skip to content

xfs: properly invalidate cached writeback mapping

Brian Foster linux-xfs 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 2 repliesIn review
  2. v36 patches 6 repliesSuperseded
  3. v25 patches 21 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches11 repliesSuperseded

Changes in v4 from the cover letter

- Fold in Christoph's interface changes from the delalloc conversion rework series (patches 5-6).
v3: https://marc.info/?l=linux-xfs&m=154826889919747&w=2
- Move comment in xfs_imap_valid().
- Replace lookup+trim in xfs_iomap_write_allocate() with xfs_bmapi_delalloc() wrapper mechanism.
v2: https://marc.info/?l=linux-xfs&m=154775280823464&w=2
- Refactor validation logic into xfs_imap_valid() helper.
- Revalidate seqno after the lock cycle in xfs_map_blocks().
- Update *seq in xfs_iomap_write_allocate() regardless of fork type.
- Add patch 5 for seqno revalidation on xfs_iomap_write_allocate() lock cycles.
v1: https://marc.info/?l=linux-xfs&m=154721212321112&w=2

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6xfs: eof trim writeback mapping as soon as it is cachedfs/xfs/xfs_aops.c+2 -00 replies
2/6xfs: update fork seq counter on data fork changesfs/xfs/libxfs/xfs_iext_tree.c fs/xfs/libxfs/xfs_inode_fork.h+7 -80 replies
3/6xfs: validate writeback mapping using data fork seq counterfs/xfs/xfs_aops.c fs/xfs/xfs_iomap.c+49 -160 replies
4/6xfs: remove superfluous writeback mapping eof trimmingfs/xfs/libxfs/xfs_bmap.c fs/xfs/libxfs/xfs_bmap.h fs/xfs/xfs_aops.c+0 -270 replies
5/6xfs: create delalloc bmapi wrapper for full extent allocationfs/xfs/libxfs/xfs_bmap.c fs/xfs/libxfs/xfs_bmap.h+59 -41 reply
6/6xfs: use the latest extent at writeback delalloc conversion timefs/xfs/libxfs/xfs_bmap.c fs/xfs/libxfs/xfs_bmap.h fs/xfs/xfs_iomap.c+64 -1241 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAllison HendersonChristoph Hellwig
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] xfs: properly invalidate cached writeback mapping

Hi all,

This is a minor update of this series to fold in some changes from Christoph's follow on series to rework the delalloc conversion code. The changes apply to patches 5 and 6 and rename/rework the delalloc helper. The subsequent series will fill in a real implementation for the wrapper and further clean up the writeback code.

Brian

v4:
- Fold in Christoph's interface changes from the delalloc conversion rework series (patches 5-6).
v3: https://marc.info/?l=linux-xfs&m=154826889919747&w=2
- Move comment in xfs_imap_valid().
- Replace lookup+trim in xfs_iomap_write_allocate() with xfs_bmapi_delalloc() wrapper mechanism.
v2: https://marc.info/?l=linux-xfs&m=154775280823464&w=2
- Refactor validation logic into xfs_imap_valid() helper.
- Revalidate seqno after the lock cycle in xfs_map_blocks().
- Update *seq in xfs_iomap_write_allocate() regardless of fork type.
- Add patch 5 for seqno revalidation on xfs_iomap_write_allocate() lock cycles.
v1: https://marc.info/?l=linux-xfs&m=154721212321112&w=2

Brian Foster (6):
xfs: eof trim writeback mapping as soon as it is cached
xfs: update fork seq counter on data fork changes
xfs: validate writeback mapping using data fork seq counter
xfs: remove superfluous writeback mapping eof trimming
xfs: create delalloc bmapi wrapper for full extent allocation
xfs: use the latest extent at writeback delalloc conversion time

 fs/xfs/libxfs/xfs_bmap.c       |  68 ++++++++++---
 fs/xfs/libxfs/xfs_bmap.h       |   3 +-
 fs/xfs/libxfs/xfs_iext_tree.c  |  13 ++-
 fs/xfs/libxfs/xfs_inode_fork.h |   2 +-
 fs/xfs/xfs_aops.c              |  71 +++++++++-----
 fs/xfs/xfs_iomap.c             | 171 +++++++++++----------------------
 6 files changed, 165 insertions(+), 163 deletions(-)
Signature · 1 line
2.17.2