Skip to content

typedefs: Remove scarcely used declarations

Philippe Mathieu-Daudé qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review
  2. v10 of 33 patches 1 replySuperseded

Changes in v2 from the cover letter

- reorder fw_cfg (Laszlo), remove forward declarations
- move PixelFormat to "ui/qemu-pixman.h" (Paolo)
- reword comment (Thomas)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/nvram/fw_cfg: Remove various typedefs from "qemu/typedefs.h"include/hw/acpi/vmgenid.h include/hw/arm/virt.h include/hw/mem/nvdimm.h +2 more+15 -144 replies
2/3ui/console: Remove MouseTransformInfo from qemu/typedefs.hinclude/hw/devices.h include/qemu/typedefs.h include/ui/console.h+3 -31 reply
3/3ui/console: Remove PixelFormat from qemu/typedefs.hinclude/qemu/typedefs.h include/ui/console.h include/ui/qemu-pixman.h+10 -111 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchLaszlo ErsekGerd Hoffmann
1/3R-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] typedefs: Remove scarcely used declarations

Hi,

Since this file became a hot topic [*], I took previous cleanups from last year and continue to clean it.

v2:
- reorder fw_cfg (Laszlo), remove forward declarations
- move PixelFormat to "ui/qemu-pixman.h" (Paolo)
- reword comment (Thomas)

Regards,

Phil.

[*] "HACKING: Clarify the paragraph about typedefs"
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg02132.html
[*] "Fix duplicated typedefs to be able to compile with Clang in gnu99 mode"
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg02117.html

Based-on: [email protected]

Philippe Mathieu-Daudé (3):
hw/nvram/fw_cfg: Remove various typedefs from "qemu/typedefs.h" ui/console: Remove MouseTransformInfo from qemu/typedefs.h ui/console: Remove PixelFormat from qemu/typedefs.h

 include/hw/acpi/vmgenid.h |  1 +
 include/hw/arm/virt.h     |  1 +
 include/hw/devices.h      |  1 +
 include/hw/mem/nvdimm.h   |  1 +
 include/hw/nvram/fw_cfg.h | 22 ++++++++++++----------
 include/qemu/typedefs.h   |  6 ------
 include/ui/console.h      | 14 ++------------
 include/ui/qemu-pixman.h  | 10 ++++++++++
 8 files changed, 28 insertions(+), 28 deletions(-)
Signature · 1 line
2.17.2