Skip to content

Misc ION cleanups and adding unmapped heap

Andrew F. Davis dri-devel lkml 1 version Applied

Status from this message: I've applied the first 10 of these to the tree, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 56 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/14staging: android: ion: Add proper header informationdrivers/staging/android/ion/ion.c drivers/staging/android/ion/ion.h drivers/staging/android/ion/ion_carveout_heap.c +5 more+8 -80 replies
2/14staging: android: ion: Remove empty ion_ioctl_dir() functiondrivers/staging/android/ion/ion-ioctl.c+2 -140 replies
3/14staging: android: ion: Merge ion-ioctl.c into ion.cdrivers/staging/android/ion/Makefile drivers/staging/android/ion/ion-ioctl.c drivers/staging/android/ion/ion.c +1 more+78 -970 replies
4/14staging: android: ion: Remove leftover commentdrivers/staging/android/ion/ion_cma_heap.c+0 -40 replies
5/14staging: android: ion: Remove struct ion_platform_heapdrivers/staging/android/ion/ion.h drivers/staging/android/ion/ion_carveout_heap.c drivers/staging/android/ion/ion_chunk_heap.c+11 -410 replies
6/14staging: android: ion: Fixup some white-space issuesdrivers/staging/android/ion/ion_carveout_heap.c drivers/staging/android/ion/ion_chunk_heap.c drivers/staging/android/ion/ion_heap.c +1 more+13 -20 replies
7/14staging: android: ion: Sync comment docs with struct ion_bufferdrivers/staging/android/ion/ion.h+7 -20 replies
8/14staging: android: ion: Remove base from ion_carveout_heapdrivers/staging/android/ion/ion_carveout_heap.c+1 -30 replies
9/14staging: android: ion: Remove base from ion_chunk_heapdrivers/staging/android/ion/ion_chunk_heap.c+2 -50 replies
10/14staging: android: ion: Remove unused headersdrivers/staging/android/ion/ion.c drivers/staging/android/ion/ion_carveout_heap.c drivers/staging/android/ion/ion_chunk_heap.c+3 -70 replies
11/14staging: android: ion: Allow heap name to be nulldrivers/staging/android/ion/ion.c+1 -14 replies
12/14staging: android: ion: Declare helpers for carveout and chunk heapsdrivers/staging/android/ion/ion.h+33 -03 replies
13/14staging: android: ion: Do not sync CPU cache on map/unmapdrivers/staging/android/ion/ion.c+4 -337 replies
14/14staging: android: ion: Add UNMAPPED heap type and helperdrivers/staging/android/ion/Kconfig drivers/staging/android/ion/Makefile drivers/staging/android/ion/ion.h +2 more+153 -05 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] Misc ION cleanups and adding unmapped heap

Hello all,

This is a set of (hopefully) non-controversial cleanups for the ION framework and current set of heaps. These were found as I start to familiarize myself with the framework to help in whatever way I can in getting all this up to the standards needed for de-staging.

I would like to get some ideas of what is left to work on to get ION out of staging. Has there been some kind of agreement on what ION should eventually end up being? To me it looks like it is being whittled away at to it's most core functions. To me that is looking like being a DMA-BUF user-space front end, simply advertising available memory backings in a system and providing allocations as DMA-BUF handles. If this is the case then it looks close to being ready to me at least, but I would love to hear any other opinions and concerns.

Back to this patchset, the last patch may be a bit different than the others, it adds an unmapped heaps type and creation helper. I wanted to get this in to show off another heap type and maybe some issues we may have with the current ION framework. The unmapped heap is used when the backing memory should not (or cannot) be touched. Currently this kind of heap is used for firewalled secure memory that can be allocated like normal heap memory but only used by secure devices (OP-TEE, crypto HW, etc). It is basically just copied from the "carveout" heap type with the only difference being it is not mappable to userspace and we do not clear the memory (as we should not map it either). So should this really be a new heap type? Or maybe advertised as a carveout heap but with an additional allocation flag? Perhaps we do away with "types" altogether and just have flags, coherent/non-coherent, mapped/unmapped, etc.

Maybe more thinking will be needed afterall..

Thanks,
Andrew

Andrew F. Davis (14):
staging: android: ion: Add proper header information
staging: android: ion: Remove empty ion_ioctl_dir() function
staging: android: ion: Merge ion-ioctl.c into ion.c
staging: android: ion: Remove leftover comment
staging: android: ion: Remove struct ion_platform_heap
staging: android: ion: Fixup some white-space issues
staging: android: ion: Sync comment docs with struct ion_buffer
staging: android: ion: Remove base from ion_carveout_heap
staging: android: ion: Remove base from ion_chunk_heap
staging: android: ion: Remove unused headers
staging: android: ion: Allow heap name to be null
staging: android: ion: Declare helpers for carveout and chunk heaps
staging: android: ion: Do not sync CPU cache on map/unmap
staging: android: ion: Add UNMAPPED heap type and helper

 drivers/staging/android/ion/Kconfig           |  10 ++
 drivers/staging/android/ion/Makefile          |   3 +-
 drivers/staging/android/ion/ion-ioctl.c       |  98 --------------
 drivers/staging/android/ion/ion.c             |  93 +++++++++++--
 drivers/staging/android/ion/ion.h             |  87 ++++++++-----
 .../staging/android/ion/ion_carveout_heap.c   |  19 +--
 drivers/staging/android/ion/ion_chunk_heap.c  |  25 ++--
 drivers/staging/android/ion/ion_cma_heap.c    |   6 +-
 drivers/staging/android/ion/ion_heap.c        |   8 +-
 drivers/staging/android/ion/ion_page_pool.c   |   2 +-
 drivers/staging/android/ion/ion_system_heap.c |   8 +-
 .../staging/android/ion/ion_unmapped_heap.c   | 123 ++++++++++++++++++
 drivers/staging/android/uapi/ion.h            |   3 +
 13 files changed, 307 insertions(+), 178 deletions(-)
 delete mode 100644 drivers/staging/android/ion/ion-ioctl.c
 create mode 100644 drivers/staging/android/ion/ion_unmapped_heap.c
Signature · 6 lines
2.19.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel