contrib/rdmacm-mux: fix clang compilation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 1 replyIn review
- v13 patches 9 repliesSuperseded
Changes in v2 from the cover letter
* Use {} construct instead memset to make both gcc and clang happy (Cornelia)
* Rebased on master
* Added Yuval's RB and Cornelia's Tested-by tags (thanks!)
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | contrib/rdmacm-mux: remove Wno-format-truncation flagcontrib/ contrib/ | +5 | 0 replies | |
| 2/3 | hw/rdma: modify struct initializationcontrib/ hw/ | +7 | 1 reply | |
| 3/3 | contrib/rdmacm-mux: fix clang compilationMakefile contrib/ | +2 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Yuval Shaia | Cornelia Huck |
|---|---|---|
| 1/3 | R-b | T-b |
| 2/3 | R-b | T-b R-b |
| 3/3 | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/3] contrib/rdmacm-mux: fix clang compilation
v1 -> v2:
* Use {} construct instead memset to make both gcc and clang happy (Cornelia)
* Rebased on master
* Added Yuval's RB and Cornelia's Tested-by tags (thanks!)
Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation
of RDMA User MAD multiplexer).
The above commit introduces a new contrib target, adding a global dependency to libumad library in case pvrdma configuration option is enabled. Clang forbids it:
clang-6.0: error: -libumad: 'linker' input unused
[-Werror,-Wunused-command-line-argument]
Fix by limiting the scope to the rdmacm-mux target itself. Fix related clang errors while at it.
Marcel Apfelbaum (3):
contrib/rdmacm-mux: remove Wno-format-truncation flag hw/rdma: modify struct initialization contrib/rdmacm-mux: fix clang compilation
Makefile | 2 ++ contrib/rdmacm-mux/Makefile.objs | 1 - contrib/rdmacm-mux/main.c | 12 +++++++----- hw/rdma/rdma_backend.c | 8 ++++---- 4 files changed, 13 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1