Skip to content

contrib/rdmacm-mux: fix clang compilation

Marcel Apfelbaum qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v13 patches 9 repliesSuperseded

Changes in v2 from the cover letter

* Use {} construct instead memset to make both gcc and clang happy (Cornelia)
* Rebased on master
* Added Yuval's RB and Cornelia's Tested-by tags (thanks!)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3contrib/rdmacm-mux: remove Wno-format-truncation flagcontrib/rdmacm-mux/Makefile.objs contrib/rdmacm-mux/main.c+5 -30 replies
2/3hw/rdma: modify struct initializationcontrib/rdmacm-mux/main.c hw/rdma/rdma_backend.c+7 -71 reply
3/3contrib/rdmacm-mux: fix clang compilationMakefile contrib/rdmacm-mux/Makefile.objs+2 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchYuval ShaiaCornelia Huck
1/3R-b T-b
2/3R-b T-b R-b
3/3R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] contrib/rdmacm-mux: fix clang compilation

v1 -> v2:
* Use {} construct instead memset to make both gcc and clang happy (Cornelia)
* Rebased on master
* Added Yuval's RB and Cornelia's Tested-by tags (thanks!)

Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation
of RDMA User MAD multiplexer).

The above commit introduces a new contrib target, adding a global dependency to libumad library in case pvrdma configuration option is enabled. Clang forbids it:
clang-6.0: error: -libumad: 'linker' input unused
[-Werror,-Wunused-command-line-argument]

Fix by limiting the scope to the rdmacm-mux target itself. Fix related clang errors while at it.

Marcel Apfelbaum (3):
contrib/rdmacm-mux: remove Wno-format-truncation flag hw/rdma: modify struct initialization contrib/rdmacm-mux: fix clang compilation

 Makefile                         |  2 ++
 contrib/rdmacm-mux/Makefile.objs |  1 -
 contrib/rdmacm-mux/main.c        | 12 +++++++-----
 hw/rdma/rdma_backend.c           |  8 ++++----
 4 files changed, 13 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1