RFC watchdog: hpwdt: Fix NMI-related behaviour when CONFIG_HPWDT_NMI_DECODING is enabled
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest4 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | watchdog: hpwdt: Don't disable watchdog on NMIdrivers/ | +0 | 6 replies | |
| 2/4 | watchdog: hpwdt: Don't panic on foreign NMIdrivers/ | +1 | 0 replies | |
| 3/4 | watchdog: hpwdt: Add more information into messagedrivers/ | +10 | 0 replies | |
| 4/4 | watchdog: hpwdt: Make panic behaviour configurabledrivers/ | +16 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/4] watchdog: hpwdt: Fix NMI-related behaviour when CONFIG_HPWDT_NMI_DECODING is enabled
Hi,
I found out that hpwdt alters NMI behaviour unexpectedly if compiled with enabled CONFIG_HPWDT_NMI_DECODING:
* System starts to panic on any NMI with misleading message.
* Watchdog provided by hpwdt is not working after such panic.
Here are the patches that should fix this.
This is an RFC patch series because I am not sure that patches are correct. Questions:
* Are "mynmi" flags always set on all supported iLO versions when iLO is the source of NMI?
* Is it safe to reset "mynmi" flags to zero if code decides to not panic?
Ivan Mironov (4):
watchdog: hpwdt: Don't disable watchdog on NMI
watchdog: hpwdt: Don't panic on foreign NMI
watchdog: hpwdt: Add more information into message
watchdog: hpwdt: Make panic behaviour configurable
drivers/watchdog/hpwdt.c | 45 ++++++++++++++++++++++------------------ 1 file changed, 25 insertions(+), 20 deletions(-)
Signature · 1 line
2.20.1