Skip to content

Add support for PCIe RC and EP mode in TI's AM654 SoC

Kishon Vijay Abraham I linux-arm-kernel linux-devicetree linux-omap linux-pci lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest26 patches 25 repliesIn review
  2. v226 patches 6 repliesSuperseded
  3. v124 patches 9 repliesSuperseded

Changes in v3 from the cover letter

*) Missed updating "Reviewed-by: Rob Herring <[email protected]>" tags
in the version that was sent to list.
*) Add const qualifier to struct dw_pcie_ep_ops in pci-layerscape-ep.c

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26PCI: keystone: Add start_link/stop_link dw_pcie_opsdrivers/pci/controller/dwc/pci-keystone.c+22 -220 replies
2/26PCI: keystone: Cleanup error_irq configurationdrivers/pci/controller/dwc/pci-keystone.c+17 -263 replies
3/26dt-bindings: PCI: keystone: Add "reg-names" binding informationDocumentation/devicetree/bindings/pci/pci-keystone.txt+4 -20 replies
4/26PCI: keystone: Perform host initialization in a single functiondrivers/pci/controller/dwc/pci-keystone.c+23 -400 replies
5/26PCI: keystone: Use platform_get_resource_byname to get memory resourcesdrivers/pci/controller/dwc/pci-keystone.c+7 -100 replies
6/26PCI: keystone: Move initializations to appropriate placesdrivers/pci/controller/dwc/pci-keystone.c+15 -120 replies
7/26dt-bindings: PCI: Add dt-binding to configure PCIe modeDocumentation/devicetree/bindings/pci/pci-keystone.txt+2 -00 replies
8/26PCI: keystone: Explicitly set the PCIe modedrivers/pci/controller/dwc/pci-keystone.c+37 -00 replies
9/26dt-bindings: PCI: Document "atu" reg-namesDocumentation/devicetree/bindings/pci/designware-pcie.txt+5 -20 replies
10/26PCI: dwc: Enable iATU unroll for endpoint toodrivers/pci/controller/dwc/pcie-designware-ep.c drivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.c+19 -230 replies
11/26PCI: dwc: Fix ATU identification for designware version >= 4.80drivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+9 -60 replies
12/26PCI: keystone: Prevent ARM32 specific code to be compiled for ARM64drivers/pci/controller/dwc/pci-keystone.c+4 -07 replies
13/26dt-bindings: PCI: Add PCI RC dt binding documentation for AM654Documentation/devicetree/bindings/pci/pci-keystone.txt+5 -10 replies
14/26PCI: keystone: Add support for PCIe RC in AM654x Platformsdrivers/pci/controller/dwc/Kconfig drivers/pci/controller/dwc/pci-keystone.c+148 -153 replies
15/26PCI: keystone: Invoke phy_reset API before enabling PHYdrivers/pci/controller/dwc/pci-keystone.c+4 -00 replies
16/26PCI: OF: Allow of_pci_get_max_link_speed() to be used by PCI Endpoint driversdrivers/pci/Makefile drivers/pci/of.c+24 -222 replies
17/26PCI: keystone: Add support to set the max link speed from DTdrivers/pci/controller/dwc/pci-keystone.c+35 -00 replies
18/26PCI: endpoint: Add support to allocate aligned buffers to be mapped in BARsdrivers/pci/endpoint/functions/pci-epf-test.c drivers/pci/endpoint/pci-epf-core.c include/linux/pci-epc.h +1 more+15 -53 replies
19/26PCI: dwc: Add const qualifier to struct dw_pcie_ep_opsdrivers/pci/controller/dwc/pci-dra7xx.c drivers/pci/controller/dwc/pci-layerscape-ep.c drivers/pci/controller/dwc/pcie-artpec6.c +2 more+5 -50 replies
20/26PCI: dwc: Fix dw_pcie_ep_find_capability to return correct capability offsetdrivers/pci/controller/dwc/pcie-designware-ep.c+5 -52 replies
21/26PCI: dwc: Add callbacks for accessing dbi2 address spacedrivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+41 -20 replies
22/26PCI: keystone: Add support for PCIe EP in AM654x Platformsdrivers/pci/controller/dwc/Kconfig drivers/pci/controller/dwc/pci-keystone.c+236 -292 replies
23/26PCI: designware-ep: Configure RESBAR to advertise the smallest sizedrivers/pci/controller/dwc/pcie-designware-ep.c+34 -00 replies
24/26PCI: designware-ep: Use aligned ATU window for raising MSI interruptsdrivers/pci/controller/dwc/pcie-designware-ep.c+5 -21 reply
25/26misc: pci_endpoint_test: Add support to test PCI EP in AM654xdrivers/misc/pci_endpoint_test.c+17 -00 replies
26/26misc: pci_endpoint_test: Fix test_reg_bar to be updated in pci_endpoint_testdrivers/misc/pci_endpoint_test.c+1 -00 replies

Reviews trailers per patch

4 of 26 patches have a Reviewed-by or Acked-by.

PatchRob HerringBjorn Helgaas
1/26
2/26
3/26R-b
4/26
5/26
6/26
7/26R-b
8/26
9/26
10/26
11/26
12/26
13/26R-b
14/26
15/26
16/26A-b
17/26
18/26
19/26
20/26
21/26
22/26
23/26
24/26
25/26
26/26

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/26] Add support for PCIe RC and EP mode in TI's AM654 SoC

Add PCIe RC support for TI's AM654 SoC. The PCIe controller in AM654 uses Synopsys core revision 4.90a and uses the same TI wrapper as used in keystone2 with certain modification. Hence AM654 will use the same pci wrapper driver pci-keystone.c

This series was initially part of [1]. This series only includes patches that has to be merged via Lorenzo's tree. The PHY patches and dt patches will be sent separately.

This series is created over keystone MSI cleanup series [2].

This series:
*) Cleanup pci-keystone driver so that both RC mode and EP mode of
AM654 can be supported
*) Modify epc-core to support allocation of aligned buffers required for
AM654
*) Fix ATU unroll identification
*) Add support for both host mode and device mode in AM654

Changes from v2:
*) Missed updating "Reviewed-by: Rob Herring <[email protected]>" tags
in the version that was sent to list.
*) Add const qualifier to struct dw_pcie_ep_ops in pci-layerscape-ep.c

Changes from v1:
*) Support for legacy interrupt in AM654 is removed (see background here
[3])
*) Allow of_pci_get_max_link_speed to be used by Endpoint controller driver
*) Add support to set max-link-speed from DT in pci-keystone driver *) Update "Reviewed-by: Rob Herring <[email protected]>" tags.

[1] -> https://lore.kernel.org/patchwork/cover/989487/
[2] -> https://lkml.org/lkml/2019/3/21/193
[3] -> https://lkml.org/lkml/2019/3/19/235

Kishon Vijay Abraham I (26):
PCI: keystone: Add start_link/stop_link dw_pcie_ops
PCI: keystone: Cleanup error_irq configuration
dt-bindings: PCI: keystone: Add "reg-names" binding information
PCI: keystone: Perform host initialization in a single function
PCI: keystone: Use platform_get_resource_byname to get memory
resources
PCI: keystone: Move initializations to appropriate places
dt-bindings: PCI: Add dt-binding to configure PCIe mode
PCI: keystone: Explicitly set the PCIe mode
dt-bindings: PCI: Document "atu" reg-names
PCI: dwc: Enable iATU unroll for endpoint too
PCI: dwc: Fix ATU identification for designware version >= 4.80
PCI: keystone: Prevent ARM32 specific code to be compiled for ARM64
dt-bindings: PCI: Add PCI RC dt binding documentation for AM654
PCI: keystone: Add support for PCIe RC in AM654x Platforms
PCI: keystone: Invoke phy_reset API before enabling PHY
PCI: OF: Allow of_pci_get_max_link_speed() to be used by PCI Endpoint
drivers
PCI: keystone: Add support to set the max link speed from DT
PCI: endpoint: Add support to allocate aligned buffers to be mapped in
BARs
PCI: dwc: Add const qualifier to struct dw_pcie_ep_ops
PCI: dwc: Fix dw_pcie_ep_find_capability to return correct capability
offset
PCI: dwc: Add callbacks for accessing dbi2 address space
PCI: keystone: Add support for PCIe EP in AM654x Platforms
PCI: designware-ep: Configure RESBAR to advertise the smallest size
PCI: designware-ep: Use aligned ATU window for raising MSI interrupts
misc: pci_endpoint_test: Add support to test PCI EP in AM654x
misc: pci_endpoint_test: Fix test_reg_bar to be updated in
pci_endpoint_test

 .../bindings/pci/designware-pcie.txt          |   7 +-
 .../devicetree/bindings/pci/pci-keystone.txt  |  14 +-
 drivers/misc/pci_endpoint_test.c              |  18 +
 drivers/pci/Makefile                          |   2 +-
 drivers/pci/controller/dwc/Kconfig            |  25 +-
 drivers/pci/controller/dwc/pci-dra7xx.c       |   2 +-
 drivers/pci/controller/dwc/pci-keystone.c     | 577 +++++++++++++++---
 .../pci/controller/dwc/pci-layerscape-ep.c    |   2 +-
 drivers/pci/controller/dwc/pcie-artpec6.c     |   2 +-
 .../pci/controller/dwc/pcie-designware-ep.c   |  55 +-
 .../pci/controller/dwc/pcie-designware-host.c |  19 -
 .../pci/controller/dwc/pcie-designware-plat.c |   2 +-
 drivers/pci/controller/dwc/pcie-designware.c  |  52 ++
 drivers/pci/controller/dwc/pcie-designware.h  |  15 +-
 drivers/pci/endpoint/functions/pci-epf-test.c |   5 +-
 drivers/pci/endpoint/pci-epf-core.c           |  10 +-
 drivers/pci/of.c                              |  44 +-
 include/linux/pci-epc.h                       |   2 +
 include/linux/pci-epf.h                       |   3 +-
 19 files changed, 683 insertions(+), 173 deletions(-)
Signature · 1 line
2.17.1