Skip to content

Add VM kernel tracing over vsock sockets

Slavomir Kaslev linux-trace-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 1 replyIn review
  2. v36 patches 5 repliesSuperseded

Changes in v4 from the cover letter

- detect and use splice(2) on vsock sockets if possible
- switch port numbers to unsigned int
- trace-cmd record --date flag is now set for all guests if provided by the user
- removed grow_cap and exponential buffer size growth

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8trace-cmd: Minor refactoringtracecmd/trace-record.c+46 -450 replies
2/8trace-cmd: Detect if vsock sockets are availableMakefile+7 -00 replies
3/8trace-cmd: Add tracecmd_create_recorder_virt functioninclude/trace-cmd/trace-cmd.h lib/trace-cmd/trace-recorder.c+39 -150 replies
4/8trace-cmd: Use unsigned int for trace-cmd client portsinclude/trace-cmd/trace-cmd.h tracecmd/trace-msg.c tracecmd/trace-record.c+6 -60 replies
5/8trace-cmd: Add TRACE_REQ and TRACE_RESP messagesinclude/trace-cmd/trace-cmd.h tracecmd/trace-msg.c+219 -11 reply
6/8trace-cmd: Add buffer instance flags for tracing in guest and agent contexttracecmd/include/trace-local.h tracecmd/trace-record.c+55 -20 replies
7/8trace-cmd: Add VM kernel tracing over vsock sockets transporttracecmd/Makefile tracecmd/include/trace-local.h tracecmd/trace-agent.c +3 more+822 -520 replies
8/8trace-cmd: Use splice(2) for vsock sockets if availabletracecmd/trace-record.c+56 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/8] Add VM kernel tracing over vsock sockets

This patchset adds support for tracing guest kernels to trace-cmd.

Changes in v4:
- detect and use splice(2) on vsock sockets if possible
- switch port numbers to unsigned int
- trace-cmd record --date flag is now set for all guests if provided by the user
- removed grow_cap and exponential buffer size growth

Changes in v3:
- addressed Steven's feedback
- detect and disable guest tracing if <linux/vm_sockets.h> is not available
- the --date flag is now treated as global for all guest instances
- fixed a bug that caused --date to be ignored for host tracing data when tracing guests

Changes in v2:
- rebased on top of protocol V3
- fixed system clock timestamps with the --date flag

Slavomir Kaslev (6):
trace-cmd: Minor refactoring
trace-cmd: Add tracecmd_create_recorder_virt function
trace-cmd: Add TRACE_REQ and TRACE_RESP messages
trace-cmd: Add buffer instance flags for tracing in guest and agent
context
trace-cmd: Add VM kernel tracing over vsock sockets transport
trace-cmd: Use splice(2) for vsock sockets if available

Steven Rostedt (VMware) (1):
trace-cmd: Detect if vsock sockets are available

Tzvetomir Stoyanov (1):
trace-cmd: Use unsigned int for trace-cmd client ports

 Makefile                       |   7 +
 include/trace-cmd/trace-cmd.h  |  17 +-
 lib/trace-cmd/trace-recorder.c |  53 ++-
 tracecmd/Makefile              |   6 +-
 tracecmd/include/trace-local.h |  18 +
 tracecmd/trace-agent.c         | 230 ++++++++++
 tracecmd/trace-cmd.c           |   3 +
 tracecmd/trace-msg.c           | 210 ++++++++-
 tracecmd/trace-record.c        | 803 +++++++++++++++++++++++++++++----
 tracecmd/trace-usage.c         |  13 +-
 10 files changed, 1243 insertions(+), 117 deletions(-)
 create mode 100644 tracecmd/trace-agent.c
Signature · 1 line
2.19.1