Skip to content

tcp: remove code from tcp_create_openreq_child()

Eric Dumazet netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11tcp: do not set snd_ssthresh in tcp_create_openreq_child()net/ipv4/tcp_minisocks.c+0 -10 replies
2/11tcp: move icsk_rto init to tcp_disconnect()net/ipv4/tcp.c net/ipv4/tcp_minisocks.c+1 -10 replies
3/11tcp: do not clear packets_out in tcp_create_openreq_child()net/ipv4/tcp_minisocks.c+0 -10 replies
4/11tcp: do not clear srtt_us in tcp_create_openreq_childnet/ipv4/tcp_minisocks.c+0 -10 replies
5/11tcp: move mdev_us init to tcp_disconnect()net/ipv4/tcp.c net/ipv4/tcp_minisocks.c+1 -10 replies
6/11tcp: move snd_cwnd & snd_cwnd_cnt init to tcp_disconnect()net/ipv4/tcp.c net/ipv4/tcp_minisocks.c+1 -90 replies
7/11tcp: do not clear urg_data in tcp_create_openreq_childnet/ipv4/tcp_minisocks.c+0 -20 replies
8/11tcp: move retrans_out,sacked_out,tlp_high_seq,last_oow_ack_time init to tcp_disconnect()net/ipv4/tcp.c net/ipv4/tcp_minisocks.c+4 -40 replies
9/11tcp: move app_limited init to tcp_disconnect()net/ipv4/tcp.c net/ipv4/tcp_minisocks.c+3 -30 replies
10/11tcp: move tp->rack init to tcp_disconnect()net/ipv4/tcp.c net/ipv4/tcp_minisocks.c+6 -60 replies
11/11tcp: move rx_opt & syn_data_acked init to tcp_disconnect()net/ipv4/tcp.c net/ipv4/tcp_minisocks.c+4 -60 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchYuchung ChengSoheil Hassas Yeganeh
SeriesA-b A-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/11] tcp: remove code from tcp_create_openreq_child()

tcp_create_openreq_child() is essentially cloning a listener, then must initialize some fields that can not be inherited.

Listeners are either fresh sockets, or sockets that came through tcp_disconnect() after a session that dirtied many fields.

By moving code to tcp_disconnect(), we can shorten time taken to create a clone, since tcp_disconnect() operation is very unlikely.

Eric Dumazet (11):
tcp: do not set snd_ssthresh in tcp_create_openreq_child()
tcp: move icsk_rto init to tcp_disconnect()
tcp: do not clear packets_out in tcp_create_openreq_child()
tcp: do not clear srtt_us in tcp_create_openreq_child
tcp: move mdev_us init to tcp_disconnect()
tcp: move snd_cwnd & snd_cwnd_cnt init to tcp_disconnect()
tcp: do not clear urg_data in tcp_create_openreq_child
tcp: move retrans_out,sacked_out,tlp_high_seq,last_oow_ack_time init
to tcp_disconnect()
tcp: move app_limited init to tcp_disconnect()
tcp: move tp->rack init to tcp_disconnect()
tcp: move rx_opt & syn_data_acked init to tcp_disconnect()

 net/ipv4/tcp.c           | 21 ++++++++++++++++++++-
 net/ipv4/tcp_minisocks.c | 34 ----------------------------------
 2 files changed, 20 insertions(+), 35 deletions(-)
Signature · 1 line
2.20.1.321.g9e740568ce-goog