Skip to content

media: imx: Disable CSI immediately after last EOF

Steve Longerbeam linux-media lkml stable 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesIn review
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Whitespace fixes
- Add Fixes: and Cc: [email protected]
- No functional changes.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2media: imx: csi: Disable CSI immediately after last EOFdrivers/staging/media/imx/imx-media-csi.c+4 -24 replies
2/2media: imx: prpencvf: Disable CSI immediately after last EOFdrivers/staging/media/imx/imx-ic-prpencvf.c+17 -91 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchPhilipp ZabelGaël PORTAY
1/2R-b T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] media: imx: Disable CSI immediately after last EOF

Disable the CSI immediately after receiving the last EOF before stream off (and thus before disabling the IDMA channel).

This fixes a complete system hard lockup on the SabreAuto when streaming from the ADV7180, by repeatedly sending a stream off immediately followed by stream on:

while true; do v4l2-ctl -d4 --stream-mmap --stream-count=3; done

Eventually this either causes the system lockup or EOF timeouts at all subsequent stream on, until a system reset.

The lockup occurs when disabling the IDMA channel at stream off. Disabling the CSI before disabling the IDMA channel appears to be a reliable fix for the hard lockup.

History:
v2:
- Whitespace fixes
- Add Fixes: and Cc: [email protected]
- No functional changes.

Steve Longerbeam (2):
media: imx: csi: Disable CSI immediately after last EOF
media: imx: prpencvf: Disable CSI immediately after last EOF

 drivers/staging/media/imx/imx-ic-prpencvf.c | 26 ++++++++++++++-------
 drivers/staging/media/imx/imx-media-csi.c   |  6 +++--
 2 files changed, 21 insertions(+), 11 deletions(-)
Signature · 1 line
2.17.1

Read the cover letter in its thread