Skip to content

mmc: sunxi: Enable DM_MMC

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20190118121741.GL27429@bill-the-cat

Versions newest first

  1. v2 Latest0 of 7 patches 0 repliesNew

Patches in v2 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 0/7] mmc: sunxi: Enable DM_MMC
Quoted 24 lines · Andre Przywara
Quoted 2 lines · On Thu, 17 Jan 2019 22:39:44 +0530 Jagan Teki <[email protected]>…

V2 for previous version[1] changes, for enabling DM_MMC on Allwinner platform.

So this is a neat and simple solution to the DM_MMC problem, to the point where I am wondering why we actually need all those DT driven clock and reset drivers in the first place.
But as I understand using plat data in this way is somewhat frowned upon and considered deprecated (although it makes a lot of sense in this context).

Also, isn't this series independent from the clock gates/reset patches? So why do you pile them on top of each other in sunxi/next?

If we really want to have the full featured DT driven clock and reset support, why not use it together:
We keep the current mod clock support in the MMC driver, but use the newly introduced clock gates and reset support via the new clock driver, mostly replacing this series. This would give us some test coverage of the new clock driver, while still avoiding to rush the MMC mod clock implementation.

Quoted 6 lines

Does that make sense? Happy to bake some patches for that on the weekend.

Btw: After talking to Tom on IRC, the DM_MMC deadline is actually _after_ the 2019.04 release, so we don't need to have DM_MMC support in this merge window.

To be clearer, I plan to mark as BROKEN and start saying we're going to remove stuff that isn't migrated, after the release. So it would be good to get things moved this release that can be moved this release. Trying to use sunxi w/o MMC isn't going to be fun :)

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190118/8315887e/attachment.sig>