Skip to content

hw: provide error checking of disable-legacy/modern property usage

Daniel P. Berrangé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesIn review
  2. v11 patch 4 repliesSuperseded

Changes in v2 from the cover letter

- Fix properties set for v2.6 machine type compat so that it only affects the virtio devices which support both legacy and modern modes.
- Revert unneccessary patch allowing optional properties in machine prop back compat

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw: report invalid disable-legacy|modern usage for virtio-1-only devshw/core/machine.c hw/display/virtio-gpu-pci.c hw/display/virtio-vga.c +4 more+73 -234 replies
2/2Revert "globals: Allow global properties to be optional"include/hw/qdev-core.h qom/object.c+0 -61 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchEduardo Habkost
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/2] hw: provide error checking of disable-legacy/modern property usage

Changed in v2:

- Fix properties set for v2.6 machine type compat so that it only affects the virtio devices which support both legacy and modern modes.
- Revert unneccessary patch allowing optional properties in machine prop back compat

Daniel P. Berrangé (2):
hw: report invalid disable-legacy|modern usage for virtio-1-only devs Revert "globals: Allow global properties to be optional"

 hw/core/machine.c             | 23 ++++++++++++++++++++---
 hw/display/virtio-gpu-pci.c   |  4 +++-
 hw/display/virtio-vga.c       |  4 +++-
 hw/virtio/virtio-crypto-pci.c |  4 +++-
 hw/virtio/virtio-input-pci.c  |  4 +++-
 hw/virtio/virtio-pci.c        | 26 ++++++++++++++++----------
 hw/virtio/virtio-pci.h        | 31 +++++++++++++++++++++++++------
 include/hw/qdev-core.h        |  3 ---
 qom/object.c                  |  3 ---
 9 files changed, 73 insertions(+), 29 deletions(-)
Signature · 1 line
2.20.1