Skip to content

commit-graph: minor cleanup and optimization

SZEDER Gábor git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 5 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2commit-graph: rename 'num_extra_edges' variable to 'num_large_edges'commit-graph.c+9 -92 replies
1/2commit-graph: rename "large edges" to "extra edges"Documentation/technical/commit-graph-format.txt builtin/commit-graph.c commit-graph.c +2 more+24 -240 replies
2/2commit-graph: don't call write_graph_chunk_large_edges() unnecessarilycommit-graph.c+2 -164 replies
2/2commit-graph: don't call write_graph_chunk_large_edges() unnecessarilycommit-graph.c+2 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] commit-graph: minor cleanup and optimization
Quoted 9 lines · Derrick Stolee
Quoted 7 lines
Quoted 6 lines

I rename these variables to 'num_large_edges', because the commit graph file format speaks about the 'Large Edge List' chunk.

However, I do find that the term 'extra' makes much more sense

Would it make sense to do the rename in the other direction?

I tend to agree that "large edge" is a misnomer.

I agree with you both. "Extra" is better.

OK, so here are the two patches with the rename done in the other direction.

These should replace the bottom two patches of the topic 'ab/commit-graph-write-progress'.

SZEDER Gábor (2):
commit-graph: rename "large edges" to "extra edges"
commit-graph: don't call write_graph_chunk_large_edges() unnecessarily

 .../technical/commit-graph-format.txt         |  4 +--
 builtin/commit-graph.c                        |  4 +--
 commit-graph.c                                | 25 ++++++++++---------
 commit-graph.h                                |  2 +-
 t/t5318-commit-graph.sh                       | 14 +++++------
 5 files changed, 25 insertions(+), 24 deletions(-)
Signature · 1 line
2.20.1.499.gf60de1223c