Skip to content

media: imx: Stop stream before disabling IDMA channels

Steve Longerbeam linux-media lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 3 repliesIn review
  2. v32 patches 6 repliesSuperseded

Changes in v4 from the cover letter

- Disabling SMFC will have no effect if both CSI's are streaming. So go back to disabling CSI before channel as in v2, but split up csi_idmac_stop such that ipu_csi_disable can still be called within csi_stop.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3media: imx: csi: Disable CSI immediately after last EOFdrivers/staging/media/imx/imx-media-csi.c+14 -30 replies
2/3media: imx: csi: Stop upstream before disabling IDMA channeldrivers/staging/media/imx/imx-media-csi.c+13 -120 replies
3/3media: imx: prpencvf: Stop upstream before disabling IDMA channeldrivers/staging/media/imx/imx-ic-prpencvf.c+17 -90 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchGaël PORTAY
1/3
2/3
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] media: imx: Stop stream before disabling IDMA channels

Repeatedly sending a stream off immediately followed by stream on can eventually cause a complete system hard lockup on the SabreAuto when streaming from the ADV7180:

while true; do v4l2-ctl -d4 --stream-mmap --stream-count=3; done

Eventually this either causes the system lockup or EOF timeouts at all subsequent stream on, until a system reset.

The lockup occurs when disabling the IDMA channels at stream off. Stopping the video data stream entering the IDMA channel before disabling the channel itself appears to be a reliable fix for the hard lockup.

In the CSI subdevice, this can be done by disabling the CSI before disabling the CSI IDMA channel, instead of after. In the IC-PRPENVVF subdevice, this can be done by stopping upstream before disabling the PRPENC/VF IDMA channel.

History:
v4:
- Disabling SMFC will have no effect if both CSI's are streaming. So go back to disabling CSI before channel as in v2, but split up csi_idmac_stop such that ipu_csi_disable can still be called within csi_stop.

v3:
- Switch to disabling the SMFC before the channel, instead of the CSI before the channel.

v2:
- Whitespace fixes
- Add Fixes: and Cc: [email protected]
- No functional changes.

Steve Longerbeam (3):
media: imx: csi: Disable CSI immediately after last EOF
media: imx: csi: Stop upstream before disabling IDMA channel
media: imx: prpencvf: Stop upstream before disabling IDMA channel

 drivers/staging/media/imx/imx-ic-prpencvf.c | 26 ++++++++-----
 drivers/staging/media/imx/imx-media-csi.c   | 42 +++++++++++++--------
 2 files changed, 44 insertions(+), 24 deletions(-)
Signature · 1 line
2.17.1