Skip to content

dm: fix various issues with bio splitting code

Mike Snitzer dm-devel linux-block 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dm: fix clone_bio() to trigger blk_recount_segments()drivers/md/dm.c+2 -61 reply
2/4dm: fix redundant IO accounting for bios that need splittingdrivers/md/dm.c+16 -02 replies
3/4dm: fix missing bio_split() pattern code in __split_and_process_bio()drivers/md/dm.c+2 -08 replies
4/4dm: fix dm_wq_work() to only use __split_and_process_bio() if appropriatedrivers/md/dm.c+12 -60 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchMing Lei
1/4R-b
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] dm: fix various issues with bio splitting code

Hi,

These mostly stable@ patches will be sent to Linus for 5.0-rc4 inclusion (would've sent today for 5.0-rc3 but I don't yet have linux-next coverage).

Just wanted to give a heads up because some of the problems fixed could bite other users of the bio_split()+generic_make_request() recursive pattern. We should probably factor out some helpers that all users could share (e.g. so they don't forget to set BIO_QUEUE_ENTERED or call trace_block_split(), etc).

Thanks,
Mike

Mike Snitzer (4):
dm: fix clone_bio() to trigger blk_recount_segments()
dm: fix redundant IO accounting for bios that need splitting
dm: fix missing bio_split() pattern code in __split_and_process_bio()
dm: fix dm_wq_work() to only use __split_and_process_bio() if appropriate

 drivers/md/dm.c | 44 ++++++++++++++++++++++++++++++++------------
 1 file changed, 32 insertions(+), 12 deletions(-)
Signature · 1 line
2.15.0