Skip to content

iommu/arm-smmu: Add support to use Last level cache

Vivek Gautam linux-arm-kernel linux-arm-msm linux-iommu lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 15 repliesIn review

Changes since v2 from the cover letter

- Split the patches into io-pgtable-arm driver and arm-smmu driver.
- Converted smmu domain attributes to a bitmap, so multiple attributes can be managed easily.
- With addition of non-coherent page table mapping support [4], this patch series now aligns with the understanding of upgrading the non-coherent devices to use some level of outer cache.
- Updated the macros and comments to reflect the use of QCOM_SYS_CACHE.
- QCOM_SYS_CACHE can still be used at stage 2, so that doens't depend on stage-1 mapping.
- Added change to disable the attribute from arm_smmu_domain_set_attr() when needed.
- Removed the page protection controls for QCOM_SYS_CACHE at the DMA API level.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3iommu/arm-smmu: Move to bitmap for arm_smmu_domain atrributesdrivers/iommu/arm-smmu.c+6 -42 replies
2/3iommu/io-pgtable-arm: Add support to use system cachedrivers/iommu/io-pgtable-arm.c drivers/iommu/io-pgtable.h include/linux/iommu.h+19 -20 replies
3/3iommu/arm-smmu: Add support to use system cachedrivers/iommu/arm-smmu.c+19 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] iommu/arm-smmu: Add support to use Last level cache

Qualcomm SoCs have an additional level of cache called as System cache, aka. Last level cache (LLC). This cache sits right before the DDR, and is tightly coupled with the memory controller. The clients using this cache request their slices from this system cache, make it active, and can then start using it. For these clients with smmu, to start using the system cache for buffers and, related page tables [1], memory attributes need to be set accordingly. This series add the required support.

This change is a realisation of following changes from downstream msm-4.9:
iommu: io-pgtable-arm: Support DOMAIN_ATTRIBUTE_USE_UPSTREAM_HINT[2]
iommu: io-pgtable-arm: Implement IOMMU_USE_UPSTREAM_HINT[3]

Changes since v2:
- Split the patches into io-pgtable-arm driver and arm-smmu driver.
- Converted smmu domain attributes to a bitmap, so multiple attributes can be managed easily.
- With addition of non-coherent page table mapping support [4], this patch series now aligns with the understanding of upgrading the non-coherent devices to use some level of outer cache.
- Updated the macros and comments to reflect the use of QCOM_SYS_CACHE.
- QCOM_SYS_CACHE can still be used at stage 2, so that doens't depend on stage-1 mapping.
- Added change to disable the attribute from arm_smmu_domain_set_attr() when needed.
- Removed the page protection controls for QCOM_SYS_CACHE at the DMA API level.

Goes on top of the non-coherent page tables support patch series [4]

[1] https://patchwork.kernel.org/patch/10302791/
[2] https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?h=msm-4.9&id=bf762276796e79ca90014992f4d9da5593fa7d51
[3] https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?h=msm-4.9&id=d4c72c413ea27c43f60825193d4de9cb8ffd9602
[4] https://lore.kernel.org/patchwork/cover/1032938/

Vivek Gautam (3):
iommu/arm-smmu: Move to bitmap for arm_smmu_domain atrributes iommu/io-pgtable-arm: Add support to use system cache iommu/arm-smmu: Add support to use system cache

 drivers/iommu/arm-smmu.c       | 28 ++++++++++++++++++++++++----
 drivers/iommu/io-pgtable-arm.c | 15 +++++++++++++--
 drivers/iommu/io-pgtable.h     |  4 ++++
 include/linux/iommu.h          |  2 ++
 4 files changed, 43 insertions(+), 6 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation