Skip to content

SCSI: cleanup debugfs usage

Greg Kroah-Hartman linux-scsi lkml 1 version Applied

Status from this message: Applied to 5.1/scsi-queue, thank you!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7scsi: bfa: no need to check return value of debugfs_create functionsdrivers/scsi/bfa/bfad_debugfs.c+0 -170 replies
2/7scsi: csiostor: no need to check return value of debugfs_create functionsdrivers/scsi/csiostor/csio_init.c+1 -51 reply
3/7scsi: fnic: no need to check return value of debugfs_create functionsdrivers/scsi/fnic/fnic_debugfs.c drivers/scsi/fnic/fnic_main.c drivers/scsi/fnic/fnic_stats.h +2 more+10 -1081 reply
4/7scsi: snic: no need to check return value of debugfs_create functionsdrivers/scsi/snic/snic_debugfs.c drivers/scsi/snic/snic_main.c drivers/scsi/snic/snic_stats.h +2 more+32 -1330 replies
5/7scsi: lpfc: no need to check return value of debugfs_create functionsdrivers/scsi/lpfc/lpfc_debugfs.c+0 -1700 replies
6/7scsi: qlogic: no need to check return value of debugfs_create functionsdrivers/scsi/qedf/qedf_debugfs.c drivers/scsi/qedi/qedi_debugfs.c+4 -311 reply
7/7scsi: qla2xxx: no need to check return value of debugfs_create functionsdrivers/scsi/qla2xxx/qla_dfs.c+1 -420 replies

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by.

PatchSatish KharatManish RangankarJohannes Thumshirn
1/7
2/7R-b
3/7A-b
4/7
5/7
6/7A-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] SCSI: cleanup debugfs usage

When calling debugfs code, there is no need to ever check the return value of the call, as no logic should ever change if a call works properly or not. Fix up a bunch of x86-specific code to not care about the results of debugfs.

Greg Kroah-Hartman (7):
scsi: bfa: no need to check return value of debugfs_create functions
scsi: csiostor: no need to check return value of debugfs_create
functions
scsi: fnic: no need to check return value of debugfs_create functions
scsi: snic: no need to check return value of debugfs_create functions
scsi: lpfc: no need to check return value of debugfs_create functions
scsi: qlogic: no need to check return value of debugfs_create
functions
scsi: qla2xxx: no need to check return value of debugfs_create
functions

 drivers/scsi/bfa/bfad_debugfs.c   |  17 ---
 drivers/scsi/csiostor/csio_init.c |   6 +-
 drivers/scsi/fnic/fnic_debugfs.c  |  88 +---------------
 drivers/scsi/fnic/fnic_main.c     |   7 +-
 drivers/scsi/fnic/fnic_stats.h    |   2 +-
 drivers/scsi/fnic/fnic_trace.c    |  17 +--
 drivers/scsi/fnic/fnic_trace.h    |   4 +-
 drivers/scsi/lpfc/lpfc_debugfs.c  | 170 ------------------------------
 drivers/scsi/qedf/qedf_debugfs.c  |  18 +---
 drivers/scsi/qedi/qedi_debugfs.c  |  17 +--
 drivers/scsi/qla2xxx/qla_dfs.c    |  43 +-------
 drivers/scsi/snic/snic_debugfs.c  | 133 +++++------------------
 drivers/scsi/snic/snic_main.c     |  14 +--
 drivers/scsi/snic/snic_stats.h    |   2 +-
 drivers/scsi/snic/snic_trc.c      |  12 +--
 drivers/scsi/snic/snic_trc.h      |   4 +-
 16 files changed, 48 insertions(+), 506 deletions(-)
Signature · 1 line
2.20.1