Skip to content

crypto: cleanup debugfs usage

Greg Kroah-Hartman linux-crypto lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7crypto: qat: no need to check return value of debugfs_create functionsdrivers/crypto/qat/qat_c3xxx/adf_drv.c drivers/crypto/qat/qat_c3xxxvf/adf_drv.c drivers/crypto/qat/qat_c62x/adf_drv.c +6 more+0 -580 replies
2/7crypto: ccrree: no need to check return value of debugfs_create functionsdrivers/crypto/ccree/cc_debugfs.c drivers/crypto/ccree/cc_debugfs.h drivers/crypto/ccree/cc_driver.c+6 -313 replies
3/7crypto: axis: no need to check return value of debugfs_create functionsdrivers/crypto/axis/artpec6_crypto.c+0 -91 reply
4/7crypto: cavium: zip: no need to check return value of debugfs_create functionsdrivers/crypto/cavium/zip/zip_main.c+11 -411 reply
5/7crypto: cavium: nitrox: no need to check return value of debugfs_create functionsdrivers/crypto/cavium/nitrox/nitrox_debugfs.c drivers/crypto/cavium/nitrox/nitrox_debugfs.h drivers/crypto/cavium/nitrox/nitrox_main.c+8 -280 replies
6/7crypto: ccp: no need to check return value of debugfs_create functionsdrivers/crypto/ccp/ccp-debugfs.c+7 -292 replies
7/7crypto: caam: no need to check return value of debugfs_create functionsdrivers/crypto/caam/ctrl.c drivers/crypto/caam/intern.h+6 -161 reply

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchHoria GeantăGary R HookLars PerssonJan GlauberGilad Ben-Yossef
1/7
2/7A-b
3/7A-b
4/7R-b
5/7
6/7A-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] crypto: cleanup debugfs usage

When calling debugfs code, there is no need to ever check the return value of the call, as no logic should ever change if a call works properly or not. Fix up a bunch of crypto-specific code to not care about the results of debugfs.

Greg Kroah-Hartman (7):
crypto: qat: no need to check return value of debugfs_create functions
crypto: ccrree: no need to check return value of debugfs_create
functions
crypto: axis: no need to check return value of debugfs_create
functions
crypto: cavium: zip: no need to check return value of debugfs_create
functions
crypto: cavium: nitrox: no need to check return value of
debugfs_create functions
crypto: ccp: no need to check return value of debugfs_create functions
crypto: caam: no need to check return value of debugfs_create
functions

 drivers/crypto/axis/artpec6_crypto.c          |  9 ----
 drivers/crypto/caam/ctrl.c                    | 21 +++-----
 drivers/crypto/caam/intern.h                  |  1 -
 drivers/crypto/cavium/nitrox/nitrox_debugfs.c | 27 ++--------
 drivers/crypto/cavium/nitrox/nitrox_debugfs.h |  5 +-
 drivers/crypto/cavium/nitrox/nitrox_main.c    |  4 +-
 drivers/crypto/cavium/zip/zip_main.c          | 52 ++++---------------
 drivers/crypto/ccp/ccp-debugfs.c              | 36 +++----------
 drivers/crypto/ccree/cc_debugfs.c             | 22 ++------
 drivers/crypto/ccree/cc_debugfs.h             |  8 +--
 drivers/crypto/ccree/cc_driver.c              |  7 +--
 drivers/crypto/qat/qat_c3xxx/adf_drv.c        |  5 --
 drivers/crypto/qat/qat_c3xxxvf/adf_drv.c      |  5 --
 drivers/crypto/qat/qat_c62x/adf_drv.c         |  5 --
 drivers/crypto/qat/qat_c62xvf/adf_drv.c       |  5 --
 drivers/crypto/qat/qat_common/adf_cfg.c       |  7 ---
 drivers/crypto/qat/qat_common/adf_transport.c |  6 ---
 .../qat/qat_common/adf_transport_debug.c      | 15 ------
 drivers/crypto/qat/qat_dh895xcc/adf_drv.c     |  5 --
 drivers/crypto/qat/qat_dh895xccvf/adf_drv.c   |  5 --
 20 files changed, 38 insertions(+), 212 deletions(-)
Signature · 1 line
2.20.1

Read the cover letter in its thread