Skip to content

gpio: mockup: improve the user-space testing interface

Bartosz Golaszewski linux-gpio lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 2 repliesIn review
  2. v57 patches 4 repliesSuperseded
  3. v47 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches1 replySuperseded
v29 patches22 repliesSuperseded
v19 patches4 repliesSuperseded

Changes in v6 from the cover letter

- same as v5, but we're now validating the trigger type and only allow edge triggers

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7irq/irq_sim: add irq_set_type() callbackkernel/irq/irq_sim.c+12 -02 replies
2/7gpio: mockup: add lockingdrivers/gpio/gpio-mockup.c+43 -70 replies
3/7gpio: mockup: implement get_multiple()drivers/gpio/gpio-mockup.c+17 -00 replies
4/7gpio: mockup: don't create the debugfs link named after the labeldrivers/gpio/gpio-mockup.c+1 -50 replies
5/7gpio: mockup: change the type of 'offset' to unsigned intdrivers/gpio/gpio-mockup.c+1 -10 replies
6/7gpio: mockup: change the signature of unlocked get/set helpersdrivers/gpio/gpio-mockup.c+8 -110 replies
7/7gpio: mockup: rework debugfs interfacedrivers/gpio/gpio-mockup.c+103 -140 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchMarc Zyngier
1/7A-b
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/7] gpio: mockup: improve the user-space testing interface

From: Bartosz Golaszewski <[email protected]>

Marc,

as discussed. This is hopefully the last version. The irq_set_type() callback now only accepts edge triggers.

v1 -> v2:
- instead of providing the irq_sim_get_type() helper, move the irq type logic into the simulator and provide a helper that allows users to specify the type of the fired interrupt

v2 -> v3:
- switch back to having irq_sim_type() and put the line state logic into the GPIO testing module

v3 -> v4:
- drop irq_sim_get_type() and use a notifier chain instead so that any change in type configuration can be pushed out to interested users
- change the locking mechanism in gpio-mockup to a spinlock as we can't take a mutex when a hardirq-safe spinlock in irq_desc is being held when the irq_set_type() callback is called
- refuse to set any other type than falling or rising edge in irq_set_config

v4 -> v5:
- drop the notifier, use irqd_set_trigger_type() instead

v5 -> v6:
- same as v5, but we're now validating the trigger type and only allow edge triggers

Bartosz Golaszewski (7):
irq/irq_sim: add irq_set_type() callback
gpio: mockup: add locking
gpio: mockup: implement get_multiple()
gpio: mockup: don't create the debugfs link named after the label
gpio: mockup: change the type of 'offset' to unsigned int
gpio: mockup: change the signature of unlocked get/set helpers
gpio: mockup: rework debugfs interface

 drivers/gpio/gpio-mockup.c | 189 +++++++++++++++++++++++++++++++------
 kernel/irq/irq_sim.c       |  12 +++
 2 files changed, 174 insertions(+), 27 deletions(-)
Signature · 1 line
2.20.1