Skip to content

nd/the-index-final small update

Nguyễn Thái Ngọc Duy git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11grep: use grep_opt->repo instead of explict repo argumentbuiltin/grep.c+24 -170 replies
2/11notes-utils.c: remove the_repository referencesbuiltin/am.c builtin/commit.c builtin/notes.c +5 more+41 -260 replies
3/11repository.c: replace hold_locked_index() with repo_hold_locked_index()apply.c cache.h merge-recursive.c +7 more+26 -160 replies
4/11checkout: avoid the_index when possiblebuiltin/checkout.c+1 -10 replies
5/11read-cache.c: kill read_index()apply.c blame.c builtin/am.c +13 more+49 -500 replies
6/11read-cache.c: replace update_index_if_able with repo_&builtin/commit.c builtin/describe.c builtin/diff.c +5 more+20 -190 replies
7/11sha1-name.c: remove implicit dependency on the_indexbuiltin/cat-file.c builtin/grep.c builtin/log.c +5 more+50 -330 replies
8/11merge-recursive.c: remove implicit dependency on the_indexbuiltin/am.c builtin/checkout.c builtin/merge-recursive.c +4 more+91 -750 replies
9/11merge-recursive.c: remove implicit dependency on the_repositorymerge-recursive.c+24 -210 replies
10/11read-cache.c: remove the_* from index_has_changes()builtin/am.c cache.h merge-recursive.c +1 more+12 -140 replies
11/11cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switchattr.c builtin/add.c builtin/am.c +52 more+58 -240 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchStefan Beller
1/11R-b
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] nd/the-index-final small update

This was noticed by Ramsay [1] and I almost forgot.

[1] http://public-inbox.org/git/[email protected]

Range-diff:
1: 4478671442 ! 1: 971d2839ab cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch

    @@ -2,12 +2,11 @@
     
         cache.h: flip NO_THE_INDEX_COMPATIBILITY_MACROS switch
     
    -    >From now on, by default index compat macros are off because they could
    +    From now on, by default index compat macros are off because they could
         hide the_index dependency. Only those in builtin can use it (and even
         so should be avoided if possible).
     
         Signed-off-by: Nguyễn Thái Ngọc Duy <[email protected]>
    -    Signed-off-by: Junio C Hamano <[email protected]>
     
      diff --git a/attr.c b/attr.c
      --- a/attr.c
    @@ -590,6 +589,15 @@
      diff --git a/repository.c b/repository.c
      --- a/repository.c
      +++ b/repository.c
    +@@
    ++/*
    ++ * not really _using_ the compat macros, just make sure the_index
    ++ * declaration matches the definition in this file.
    ++ */
    ++#define USE_THE_INDEX_COMPATIBILITY_MACROS
    + #include "cache.h"
    + #include "repository.h"
    + #include "object-store.h"
     @@
      /* The main repository */
      static struct repository the_repo;
Signature · 1 line
2.20.1.560.g70ca8b83ee