fix qmp-cont vs migration-finish race-crash
Status from this message: Thanks, applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | qmp: forbid qmp_cont in RUN_STATE_FINISH_MIGRATEqmp.c | +3 | 1 reply | |
| 2/2 | iotest: fix 169: do not run qmp_cont in RUN_STATE_FINISH_MIGRATEtests/ | +6 | 2 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Dr. David Alan Gilbert | Max Reitz |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/2] fix qmp-cont vs migration-finish race-crash
Hi.
It's a simple fix for problems reported in "Aborts in iotest 169" by Max:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg05907.html
In thread Kevin described that a problem itself is bigger and needs more effort:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06136.html
So, we may continue discussion in "Aborts in iotest 169", and in parallel apply these patches at least as a temporary fix.
The problem of this fix is that we finally have a bit weird interface:
User gets event MIGRATION_COMPLETED, and after it he can get error message "Migration is not finalized yet".
But it is better than crash, anyway.
Vladimir Sementsov-Ogievskiy (2):
qmp: forbid qmp_cont in RUN_STATE_FINISH_MIGRATE
iotest: fix 169: do not run qmp_cont in RUN_STATE_FINISH_MIGRATE
qmp.c | 3 +++ tests/qemu-iotests/169 | 7 ++++++- 2 files changed, 9 insertions(+), 1 deletion(-)
Signature · 1 line
2.18.0