Skip to content

fix qmp-cont vs migration-finish race-crash

Vladimir Sementsov-Ogievskiy qemu-devel 1 version Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2qmp: forbid qmp_cont in RUN_STATE_FINISH_MIGRATEqmp.c+3 -01 reply
2/2iotest: fix 169: do not run qmp_cont in RUN_STATE_FINISH_MIGRATEtests/qemu-iotests/169+6 -12 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchDr. David Alan GilbertMax Reitz
1/2R-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] fix qmp-cont vs migration-finish race-crash

Hi.

It's a simple fix for problems reported in "Aborts in iotest 169" by Max:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg05907.html

In thread Kevin described that a problem itself is bigger and needs more effort:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06136.html

So, we may continue discussion in "Aborts in iotest 169", and in parallel apply these patches at least as a temporary fix.

The problem of this fix is that we finally have a bit weird interface:

User gets event MIGRATION_COMPLETED, and after it he can get error message "Migration is not finalized yet".

But it is better than crash, anyway.

Vladimir Sementsov-Ogievskiy (2):
qmp: forbid qmp_cont in RUN_STATE_FINISH_MIGRATE
iotest: fix 169: do not run qmp_cont in RUN_STATE_FINISH_MIGRATE

 qmp.c                  | 3 +++
 tests/qemu-iotests/169 | 7 ++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)
Signature · 1 line
2.18.0