Skip to content

device connection: Add support for device graphs

Heikki Krogerus linux-usb lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 6 repliesIn review
  2. v29 patches 15 repliesSuperseded
  3. v18 patches 10 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9platform/x86: intel_cht_int33fe: Prepare for better mux naming schemedrivers/platform/x86/intel_cht_int33fe.c+7 -11 reply
2/9usb: typec: Rationalize the API for the muxesdrivers/usb/typec/class.c drivers/usb/typec/mux.c include/linux/usb/typec_mux.h+10 -100 replies
3/9platform/x86: intel_cht_int33fe: Remove old style mux connectionsdrivers/platform/x86/intel_cht_int33fe.c+6 -150 replies
4/9device connection: Add fwnode member to struct device_connectioninclude/linux/device.h+6 -00 replies
5/9usb: typec: mux: Find the muxes by also matching against the device nodedrivers/usb/typec/mux.c+74 -120 replies
6/9usb: roles: Find the muxes by also matching against the device nodedrivers/usb/roles/class.c include/linux/usb/role.h+20 -30 replies
7/9usb: typec: Find the ports by also matching against the device nodedrivers/usb/typec/class.c+21 -31 reply
8/9device connection: Prepare support for firmware described connectionsdrivers/base/devcon.c+24 -00 replies
9/9device connection: Find device connections also from device graphsdrivers/base/devcon.c+35 -30 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchHans de GoedeAndy ShevchenkoJun Li
1/9R-b R-b R-b
2/9R-b R-b R-b
3/9R-b R-b R-b
4/9A-b R-b R-b
5/9A-b R-b R-b
6/9A-b R-b R-b T-b
7/9A-b R-b R-b
8/9A-b R-b R-b T-b
9/9A-b R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/9] device connection: Add support for device graphs

Hi,

This is the third version of my proposal to add device graph parsing to the device connection API. There was only one problem reported in v2 by Jun - kernel-doc entry was missing for the new fwnode member in struct usb_role_switch_desc - and it's now fixed.

The second version of the series:
https://lkml.org/lkml/2019/1/30/622

The commit message from v1:

This series adds support for OF and ACPI device graph parsing to the device connection API.

Handling the graph is straightforward, but because I'm adding that fwnode member to struct device_connection, I had to make sure all the existing users consider it.

The plan is to only support matching with fwnode in the future, so no more device name matching. The software fwnodes that we now have in kernel should make that possible, once we add support for references to them.

The original RFC:
https://lkml.org/lkml/2018/10/24/619

thanks,

Heikki Krogerus (9):
platform/x86: intel_cht_int33fe: Prepare for better mux naming scheme
usb: typec: Rationalize the API for the muxes platform/x86: intel_cht_int33fe: Remove old style mux connections device connection: Add fwnode member to struct device_connection
usb: typec: mux: Find the muxes by also matching against the device
node
usb: roles: Find the muxes by also matching against the device node
usb: typec: Find the ports by also matching against the device node device connection: Prepare support for firmware described connections device connection: Find device connections also from device graphs

 drivers/base/devcon.c                    | 62 ++++++++++++++-
 drivers/platform/x86/intel_cht_int33fe.c | 15 ++--
 drivers/usb/roles/class.c                | 21 +++++-
 drivers/usb/typec/class.c                | 31 ++++++--
 drivers/usb/typec/mux.c                  | 96 ++++++++++++++++++++----
 include/linux/device.h                   |  6 ++
 include/linux/usb/role.h                 |  2 +
 include/linux/usb/typec_mux.h            |  3 +-
 8 files changed, 196 insertions(+), 40 deletions(-)
Signature · 1 line
2.20.1